Repository navigation
fix(button): forward expanded state to the interactive control - #5148
Open
pemalama12 wants to merge 1 commit into
Open
pemalama12 wants to merge 1 commit into
pemalama12 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Found potential problems with the pull request:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A Button used to show or hide content does not expose its expanded state on the interactive control.
For example,
<Button aria-expanded={open} onPress={toggle}>Details</Button>putsaria-expandedon the outer Surface. The element withrole="button"has no expanded state. Assistive technology cannot tell whether the content is open.Forward
aria-expandedto TouchableRipple alongside the existing accessibility props. The public prop type already supports this attribute.Related issue
No existing issue found for this specific Button behavior. The reproduction and before/after results are included below.
Screenshots / Videos
No visual change.
Verified the actual DOM and accessibility tree in the running Expo web example:
truearia-expanded="true"falsearia-expanded="false"After the fix, the outer Surface no longer carries the attribute.
Test plan
To repeat the manual web check:
onPresshandler. Passaria-expanded={true}to one andaria-expanded={false}to the other.aria-expanded.Verified these steps in the Codex in-app browser with the repository's Expo example app. I did not run iOS or Android device tests.
Automated validation with Node 24.13.0 and Yarn 4.9.1:
yarn test --maxWorkers=2: 704 passed, 1 skipped; all 234 snapshots passed.yarn typecheck: passed.yarn lint: passed.yarn prepack: passed.