Simlock lease stays held after agent-device close when the CLI runs without --json #613

Activity

1. V3RON

   added

   bug:readyAn agent may fix it.An agent may fix it.

   on Oct 16, 2026
2. V3RON commented on Oct 16, 2026

   

   V3RON

   on Oct 16, 2026

   ContributorAuthor

   More actions

   Reproduction

   Failing test on branch bug/613-repro: "a close streamed in agent-device's own line shape releases the simlock lease" in src/agent-device/edge.test.ts.

   pnpm exec vitest run --project unit src/agent-device/edge.test.ts -t "streamed"

   It fails with the simlock lease still listed (expected [ '00000000000000000000000000000001' ] to deeply equal []). The two existing streamed tests pass.

   Root cause

   Defect.

   Without --json, the agent-device 0.21.28 CLI asks for progress streaming (meta.requestProgress: "command", agent-device src/cli.ts:843-861). The agent-device daemon then answers /rpc as NDJSON lines: {"type":"progress",...}, then {"type":"response","response":{jsonrpc,id,result:{ok,data:{endedLeases}}}} (agent-device packages/daemon/src/server/http/http-server.ts:662-667, packages/daemon-contracts/src/request-progress-protocol.ts:49).

   idsInFrame (src/agent-device/front/ended.ts:19) reads result.data.endedLeases and error.data.details.endedLeases only at the top of each line, never under response. So releaseEndedLeases (called at src/agent-device/front/front.ts:171) finds no ids and never releases the simlock lease.

   The sequence that leaves the simlock lease held:

   1. The agent-device daemon closes its agent-device session and ends the agent-device lease.
   2. The simlock front misses endedLeases.
   3. The renewal when the command's body ends (src/agent-device/front/renewals.ts) renews the simlock lease for a full TTL.
   4. The agent-device CLI reads the reply correctly and forgets the agent-device lease, so disconnect sends no release.

   The simlock lease is held until its TTL runs out. With --json the reply is plain JSON and is read correctly, which is why the first run released.

   The existing streamed test (src/agent-device/edge.test.ts:1273) uses a made-up line shape ({result:{data:{endedLeases}}}). The slow lane always passes --json (e2e/helpers/agent-device.ts:142,149). Neither catches this.

   Simplest fix

   In idsInFrame, when a line has type: "response", read the JSON-RPC answer from its response field. Make the fake's streamed lines and the test at edge.test.ts:1273 use agent-device's real shape.

   Alternatives rejected

   • Strip meta.requestProgress so replies are never streamed: the CLI would lose its progress output.
   • Have the agent-device CLI send a release after close: upstream removed that on purpose (feat(cli): release the proxy lease after close callstack/agent-device#3477), and simlock cannot fix it alone.
   • Scan every nested object for endedLeases: reads ids from places agent-device never puts them.

   Risk

   • A future agent-device reply shape could move the answer again; the test pins today's shape.
   • After the fix, the end-of-body renewal still runs once before the release lands. It is harmless, since the release follows.

   Side findings

   • releaseEndedLeases ends in .catch(() => undefined) (src/agent-device/front/ended.ts:57): a failed body read or lease.release is dropped with no log and no retry. Not confirmed as a leak; not filed.
3. V3RON

   self-assigned this

   on Oct 16, 2026
4. V3RON

   added 2 commits that reference this issue on Oct 16, 2026

   fix(agent-device): read endedLeases from a streamed type:response line (

   ...

   4ea8ef8

   test(agent-device): streamed fixtures use agent-device's real line sh…

   ...

   b49d550
5. V3RON

   closed this as completedin #615on Oct 16, 2026
6. V3RON commented on Oct 16, 2026

   

   V3RON

   on Oct 16, 2026

   ContributorAuthor

   More actions

   Delivery run

   Merged: #615 (#613)

   Written by an agent.