Repository navigation
chore(agents): the process review's small fixes and counters - #796
Merged
Merged
Conversation
The spec checker pads no notes; the budget guard counts awake time, not wall time; pr-body-check requires the Review ledger comment; review-inputs.sh maps the previous commit across a rebase by patch-id instead of refusing; findings carry the round that raised them and the ledger comment the commit of each round; instruction-reads.mjs and delivery-counters.mjs print the numbers the process review's delivery and instruction changes are judged by (PROCESS-REVIEW-2026-10-21.md, items 3, 19 to 22, harness pieces 5 and 6).
V3RON
added this pull request to stack #797
October 21, 2026 08:19
V3RON
marked this pull request as ready for review
October 21, 2026 08:54
V3RON
marked this pull request as draft
October 21, 2026 08:57
…and the ledger rule has its cases
V3RON
marked this pull request as ready for review
October 21, 2026 09:04
V3RON
added a commit
that referenced
this pull request
Oct 21, 2026
…d CI failures are triaged before a fix run (#798) ## What this is Layer three of `docs/internal/PROCESS-REVIEW-2026-10-21.md`: the delivery and stack changes, items 9 to 12. Stacked on #796. - Item 9: `stack-sync.sh <top pr>` reads the chain from GitHub and merges forward, bottom to top, in temporary worktrees. A merge is a fast-forward push, so no rebase, no force push and no human in the loop; `gh stack rebase` failed 11 of 14 times in the last runs, the one run that merged forward needed nobody. The deliver skill links each PR into the stack as soon as its draft exists. The ADR index merges by union (`.gitattributes`) and `src/adr-index.test.ts` keeps it complete and ordered; ADR 0022 had no row. - Item 10: before the first build the ADR branch is merged up to `main`, so tasks stop inheriting red CI (the docs-manuals test was 8 of 28 CI lines). - Item 11: the ADR PR is reviewed at run start, in parallel with the first build, instead of when the gate refuses. - Item 12: `ci-triage.mjs <pr>` sorts each failed test as flaky, base-inherited, in the PR's reach, or unknown; only reach gets an implementer, the rest a rerun or a sync. `ci-failures.mjs --branch <name>` reads a branch's newest run for the base comparison. The fix brief's `stack:` line now means "merge the named parent into your branch"; delivery rule 15 says a stack moves by merging forward. ## Judged by `delivery-counters.mjs --since <date>` on the next feature runs: CI lines sent to fix runs (26 over the last 20 merged PRs), stack syncs (12), empty builds (2), no-change fix runs (6); and gate refusals per run (two of four runs). *Written by an agent.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
The first layer of changes from
docs/internal/PROCESS-REVIEW-2026-10-21.md: the ones that need no replay to judge, and the two measuring scripts the delivery and instruction changes depend on. Stacked on #794.clock.mjsalready used, so a laptop that sleeps does not spend its session budget (The warm pool learns what to keep warm, with no configuration #771 lost its audit that way).awake.mjsis the shared helper.pr-body-check.mjsfails a PR whose Review section names a review that ran but has no## Review ledgercomment (four of the last fifteen delivery PRs had none).review-inputs.sh <pr> <previous> <previous base>maps a previous commit across a rebase when every commit's patch-id matches, instead of refusing and leaving the coordinator to self-check; the reviewer and the deliver skill pass the base after a rebase or stack sync.Round <r>: <commit>line per check, so a round can be frozen and replayed from GitHub alone.replay-freeze.mjschecks against those lines.instruction-reads.mjs(how often each role opens each rule, brief and manual) anddelivery-counters.mjs(CI lines sent to fix runs, stack syncs, empty builds, no-change fix runs, tests per Tests line, per merged PR).transcripts.mjsholds the transcript helpers the three measuring scripts share.Baseline the counters print today
PRs merged since 2026-10-20: 26 CI lines, 12 stack syncs, 2 empty builds, 6 no-change fix runs, 200 tests over 128 Tests lines, test/src LOC 1.4. Build implementers opened their brief in 23 of 38 runs and
testing.mdin 5.Written by an agent.