Repository navigation
fix(contract): an exact osVersion is bounded like a component version - #895
Merged
Merged
Conversation
Contributor
Author
Review (maintainer's agent, round 1)No blocking findings.
Note, no change needed: the one-off timing failures across |
V3RON
marked this pull request as ready for review
October 26, 2026 09:45
V3RON
force-pushed
the
security/os-version-bound
branch
from
October 26, 2026 10:29
6397864 to
de0ff5f
Compare
V3RON
force-pushed
the
security/os-version-bound
branch
from
October 26, 2026 10:37
de0ff5f to
926718e
Compare
V3RON
force-pushed
the
security/os-version-bound
branch
from
October 26, 2026 14:25
926718e to
6c8c1b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lease.requestaccepted any non-empty exactosVersion. WithallowDownload: trueand a downloadable missing runtime, that raw string went to the installer, skippingcomponentVersionSchema's bound. On iOS it reachedxcodebuild -buildVersion <raw>; on Android a;could add segments to sdkmanager's package path.An exact
osVersionmust now passcomponentVersionSchema, which also refuses;. Ranges are parsed as before.Changes
src/contract/operations.ts:refuseBadOsVersionchecks an exact constraint againstcomponentVersionSchema; a failure is a 400BAD_REQUESTon pathosVersionthat states the rule.src/contract/protocol.ts:PROTOCOL_VERSION_RANGE61 → 62; the contract and daemon manuals match.choosing-a-device.mdxstates the bound.src/daemon/server.test.ts: the long-component test now has the fake driver name the 65-character component, since such anosVersionis refused.Tests
src/contract/operations.test.ts: refuses"17.0 -foo","-1","34;extras", 65 characters, a control character and a leading space, each with its message; accepts 64 characters and the range forms.component.installrefuses"35;extras".Assumptions
minmove withmax? — yes; no compatibility path stays, since an older client differs only in a malformed exactosVersionbeing refused.Review
Spec review: skipped. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: skipped.
Rounds: 1. Tokens: n/a.
One combined review by the maintainer's agent on 2026-10-22 (comment below); no blocking findings.
Rebased onto
maine1f2f43 on 2026-10-26 as one commit. Main is at protocol 61, so this PR now bumps to 62 (was 58); thesrc/contractandsrc/daemonmanuals follow (main's still said 59).src/daemon/server.test.tskeeps this PR's version of the oversized-component test, without main's 65-characterosVersionthat the new bound refuses.Written by an agent.