Skip to content

docs(adr): 0045 a device's screen streams to operators, not a lease's (#906) - #908

Merged
V3RON merged 10 commits into
mainfrom
feature/906-adr
Oct 23, 2026
Merged

V3RON merged 10 commits into
mainfrom
feature/906-adr

Conversation

@V3RON

@V3RON V3RON commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Proposed ADR for #906. Accepted at the spec session's final approval; stays open at the bottom of the feature's stack.

Status

Review: round 1 passed Gate: waiting for the stack

Review

Spec review: 0 blocking, 0 fixed, 2 notes. Code review: skipped. Claims review: skipped.
Rounds: 1. Tokens: 0.9M.
Runs: 2. Cost USD: 0.9654. Agent seconds: 397.

Assessment: complete

Written by an agent.

@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

ADR number clash: #907 (for #905) reserved ADR 0044 at 08:59:52Z, 47 s before this PR. Please take the next free number (0045) here.

Written by an agent.

@V3RON V3RON changed the title docs(adr): 0044 a device's screen streams to operators, not a lease's (#906) docs(adr): 0045 a device's screen streams to operators, not a lease's (#906) Oct 23, 2026
@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: ff203a4

Spec review only (ADR-only). Assessment: complete. No blocking findings.

  • R1 (note): the Consequences line calls ADR 0040 a stream-route "example"; 0040 §4 decides the document lists GET /v1/stream/leases/{id}. Say whether the device route is listed.
  • R2 (note): "Every daemon serves" the public route, but under ADR 0039 a joined worker has HTTP off. Say standalone workers and gateways.
{"findings":[{"id":"R1","role":"spec","class":"ADR consequence misstates accepted ADR","outcome":"nonblocking","path":"docs/internal/adr/0045-a-devices-screen-streams-to-operators-not-a-leases.md","round":"1"},{"id":"R2","role":"spec","class":"contradicts accepted ADR wording","outcome":"nonblocking","path":"docs/internal/adr/0045-a-devices-screen-streams-to-operators-not-a-leases.md","round":"1"}]}

Written by an agent.

@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Review notes

Not blocking, not verified. Each is one reviewer's claim.

  • spec: docs/internal/adr/0045-a-devices-screen-streams-to-operators-not-a-leases.md:73 calls ADR 0040's stream route an "example", but 0040 §4 lists GET /v1/stream/leases/{id} in the OpenAPI document; 0045 does not say whether the device route is listed.
  • spec: docs/internal/adr/0045-a-devices-screen-streams-to-operators-not-a-leases.md:24 says "Every daemon serves" the route; under ADR 0039 a joined worker has HTTP off. Name standalone workers and gateways.

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review October 23, 2026 10:21
@V3RON
V3RON added this pull request to stack #925 October 23, 2026 10:37
@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Fix-check after stack sync: 729804c — ADR index row 0045 moved below 0044 after main's ADR 0044 merged in; verified by coordinator, mechanical.

Written by an agent.

@V3RON
V3RON merged commit 91b6c20 into main Oct 23, 2026
27 checks passed
@V3RON
V3RON deleted the feature/906-adr branch October 23, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant