Repository navigation
Conversation
V3RON
added this pull request to stack #925
October 23, 2026 11:40
Contributor
Author
Review ledgerRound 1: be9df5f {"findings":[{"id":"R1","role":"code","class":"testing 3 deletable behaviour stays green","outcome":"fixed","fix":"902da6e40e36e5613ff68205ba5a4524ccaec00a","path":"ui/src/screens/fleet/screen-panel.tsx","round":"1"}]}
Written by an agent. |
V3RON
marked this pull request as ready for review
October 23, 2026 12:30
This was referenced Oct 23, 2026
…een spec presses Escape on a painted picture (#910)
Contributor
Author
|
Fix-check after stack sync: f2af24e — Written by an agent. |
10 tasks done
V3RON
added a commit
that referenced
this pull request
Oct 23, 2026
…ry (#943) Closes #911 ### Status Implement: done (4/4 green) Review: round 2 passed, 1 fixed Hardware: n/a Gate: waiting for the stack ## Done when - [x] `pnpm test`, `pnpm test:e2e e2e/gateway-event-relay.test.ts` and `pnpm test:console` pass, with the four Tests lines: `e2e/gateway-event-relay.test.ts` "a gateway pages its events by worker…"; `src/http/app.test.ts` (`GET /v1/events?worker=` rows and the `before`/`limit`/`worker` dispatch); `src/history/history.test.ts` "reads a worker's events without the database or the index…"; `e2e/console/workers.spec.ts:784`. Checked: audit runs, 7/7 tests probed red; review R1 fix added `ui/src/state/worker-events.test.tsx`. - [x] `events.mdx` documents `worker`; `console.mdx` lists the worker page's four tabs. Checked: claims review, rounds 1 and 2. - [x] The OpenAPI document lists `worker` on `GET /v1/events`. Checked: `src/http/openapi.test.ts`. #906 Completion conditions: - [x] An operator opens a `ready` unleased device, picks Screen and sees its picture, on a gateway and a single worker: #923 (#909) slow lane `slow-ios-stream` / `slow-android-stream` passed; #928 (#910) `screen.spec.ts`. - [x] The picture keeps running when an agent leases the device, and stops before the device resets after the lease ends: #923 (#909) `stream-gateway.e2e.test.ts` and slow lane. - [x] An agent token gets 404 `UNKNOWN_DEVICE` from the stream route: #923 (#909) Tests lines. - [x] `GET /v1/stream/leases/{id}` answers 404 and the lease drawer has no Screen tab: #928 (#910) `openapi.test.ts`, `leases.spec.ts`. - [x] The ⓘ button shows the stream numbers, not under the picture: #928 (#910) `screen.spec.ts:387`. - [x] The Events tab fills the page and scrolls back to the worker's oldest kept event or the cap: this PR, `workers.spec.ts:784`, `gateway-event-relay.test.ts`. - [x] The layout checks pass in the browser lane: #924 (#912) `layout.spec.ts`. ## Assumptions - Assumption: protocol bumped 59 to 60. ## Review Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 1 blocking, 1 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes. Rounds: 2. Tokens: 31.8M. Runs: 10. Cost USD: 6.4136. Agent seconds: 5202. Assessment: complete *Written by an agent.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #910
Status
Implement: done (5/5 green) Review: fix-check passed Hardware: n/a Gate: waiting for the stack
pnpm testandpnpm test:consolepass, with the five Tests lines. Checked: audit and fix runs (screen.spec.ts,leases.spec.ts,ui/src/model/screen.test.ts,src/stream/service.test.ts); the full suites run in CI on the stack.rg -l "stream/leases" src ui e2e website docs/internal --glob '!docs/internal/adr/**'lists only the test that proves the old path answers 404. Checked: audit sweep./v1/stream/leases/{id}. Checked:src/http/openapi.test.ts.console.mdx,watching-the-screen.mdx,ui/AGENTS.md,src/stream/AGENTS.mdand DESIGN.md's drawer rule describe the device drawer's Screen tab. Checked: claims review, round 1.Assumptions
none
Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 1 blocking, 1 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 2. Tokens: 11.8M.
Runs: 12. Cost USD: 8.9435. Agent seconds: 5778.
Assessment: complete
Written by an agent.