Skip to content

fix(ports): a worker redials a gateway that vanished without closing the uplink - #942

Merged
V3RON merged 6 commits into
mainfrom
bug/941
Oct 23, 2026
Merged

V3RON merged 6 commits into
mainfrom
bug/941

Conversation

@V3RON

@V3RON V3RON commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Closes #941

Status

Implement: done (3/3 green) Review: round 1 passed, 0 findings Hardware: n/a Gate: running
Next: gate

  • While the uplink is open, ping every 15s and terminate when no pong arrived since the previous ping (src/ports/uplink-websocket.test.ts, probed by breaking terminate and the pong reset)
  • Healthy link stays open across ping rounds (same file, probed by breaking the pong reset)
  • Outbound WebSocket has handshakeTimeout: 10_000; a stalled handshake fails with UplinkError (same file, probed by removing the timeout)

Assumptions

  • Assumption: how a test sees the 10s handshake timeout — WebSocketUplinkConnector takes an optional handshakeTimeoutMs (default the constant); no config key.

Review

Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 1.3M.
Runs: 6. Cost USD: 2.0268. Agent seconds: 1214.

Assessment: complete

Written by an agent.

@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: df01811

Runs: 6. Cost USD: 2.0268. Agent seconds: 1214.
Tokens input 164, output 52728, cache read 3399209, cache write 260386.
- build implementer: claude-sonnet-5-5 442 s $0.4431
- audit implementer: claude-sonnet-5-5 112 s $0.1212
- review 1 reviewer: claude-sonnet-5-5 362 s $0.2736
- review 1 spec: claude-sonnet-5-5 16 s $0.1036
- review 1 code both: claude-opus-5-5 269 s $1.0167
- review 1 claims: claude-sonnet-5-5 13 s $0.0686
Finding outcomes: {}. Classes: {}.
{"findings": []}

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review October 23, 2026 18:15
@V3RON
V3RON merged commit cac23e0 into main Oct 23, 2026
52 checks passed
@V3RON
V3RON deleted the bug/941 branch October 23, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A worker never redials a gateway that vanished without closing the uplink

1 participant