Skip to content

fix(http): an Android lease over HTTP names its adb serial as address - #953

Merged
V3RON merged 3 commits into
mainfrom
bug/817
Oct 23, 2026
Merged

V3RON merged 3 commits into
mainfrom
bug/817

Conversation

@V3RON

@V3RON V3RON commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Closes #817

Status

Implement: done (1/1 green) Review: round 1 + fix-check, passed Hardware: n/a Gate: running
Next: gate

Done when

  • The HTTP lease object carries an optional address (the adb serial on Android) on the POST, the request poll and GET /v1/leases/:id (src/http/tracker.ts, test in src/http/app.test.ts). Checked by the triage test, which now passes on all three routes; the audit removed the address spread and the test went red on each.
  • address is declared in the OpenAPI lease schema (src/http/lease-declarations.ts). Checked by reading src/http/lease-declarations.ts:17 in review; CI's website job runs check-openapi.mjs on the generated document.
  • remote-agents.mdx tells Android users to use adb -s <address>. Checked in review: lines 152-153 say so, and the example response at line 93 now shows address (fix a4c29a6).

Assumptions

none

Review

Spec review: 1 blocking, 1 fixed, 0 notes. Code review: 1 blocking, 1 fixed, 1 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 1.6M.
Runs: 8. Cost USD: 1.708. Agent seconds: 950.

Assessment: complete

Written by an agent.

@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: 572ae84
Round fix-check: a4c29a6

Runs: 8. Cost USD: 1.708. Agent seconds: 950.
Tokens input 210, output 35957, cache read 3224081, cache write 269012.
- build implementer: claude-sonnet-5-5 124 s $0.1352
- audit implementer: claude-sonnet-5-5 105 s $0.184
- review 1 reviewer: claude-sonnet-5-5 282 s $0.1971
- review 1 reviewer spec: claude-sonnet-5-5 54 s $0.1314
- review 1 reviewer both: claude-opus-5-5 193 s $0.7061
- review 1 reviewer claims: claude-sonnet-5-5 65 s $0.1365
- fix 1 implementer: claude-sonnet-5-5 68 s $0.1284
- review fix-check reviewer: claude-sonnet-5-5 59 s $0.0893
Finding outcomes: {"duplicate":1,"fixed":1,"nonblocking":1}. Classes: {"docs example omits lease address":2,"no test pins address in lease payload":1}.
{"findings":[{"id":"R1","role":"spec","class":"docs example omits lease address","outcome":"fixed","path":"website/src/content/docs/docs/using-devices/remote-agents.mdx","round":"1","fix":"a4c29a6cde5c8e812956884e11599d19b58c7b82"},{"id":"R1b","role":"code","class":"docs example omits lease address","outcome":"duplicate","canonicalId":"R1","path":"website/src/content/docs/docs/using-devices/remote-agents.mdx","round":"1"},{"id":"R2","role":"code","class":"no test pins address in lease payload","outcome":"nonblocking","path":"src/http/lease-declarations.ts","round":"1"}]}

Written by an agent.

@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Review notes

Not blocking, not verified. Each is one reviewer's claim.

  • code: src/http/lease-declarations.ts:17 no test pins address in leasePayloadSchema; deleting it leaves the unit tests green (CI's check-openapi.mjs covers the generated document)

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review October 23, 2026 19:12
@V3RON
V3RON merged commit 3de46d1 into main Oct 23, 2026
63 of 66 checks passed
@V3RON
V3RON deleted the bug/817 branch October 23, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android leases over HTTP give no adb serial: udid is the AVD name

1 participant