[V3RON]

ADR for #962. Accepted — not yet implemented. Stays open at the bottom of the feature's stack and merges with #968.

Status

Implement: n/a Review: fix-check passed Hardware: n/a Gate: waiting for the stack

Review

Spec review: 4 blocking, 3 fixed, 2 notes. Code review: skipped. Claims review: skipped.
Rounds: 2. Tokens: 2.2M.
Runs: 7. Cost USD: 1.4777. Agent seconds: 629.
Assessment: complete

R2 is a duplicate of R4 (fixed in b8ffd97). R3 was decided in delivery, pending the maintainer: see the Decision taken comment.

Written by an agent.

[V3RON]

Findings (round 1, 971bdb6, spec lens only, ADR-only)

• R1 (blocking) docs/internal/adr/0048-an-ios-worker-may-keep-its-simulators-in-xcodes-device-set.md:37 — moves ownership proof, reality and purge into Xcode's default set; safety rules 1, 7, 8, 9 forbid that and the PR does not amend them (as ADR 0022 did for physical devices).
• R2 (blocking) docs/internal/adr/0048-an-ios-worker-may-keep-its-simulators-in-xcodes-device-set.md:6 — narrows ADR 0001 but 0001's Status line does not point at 0048 (adr/README.md requires it).
• R3 (blocking) docs/internal/adr/0048-an-ios-worker-may-keep-its-simulators-in-xcodes-device-set.md:45 — a worker leaving a custom deviceRoot for default strands the old root's devices; §3 checks only the default Simlock set. Decide refusal while registry holds iOS virtual devices, or name the old root.

Assessment: complete. Findings file: /var/folders/tb/j39z273s5kn7lb9tz1dhk8l00000gn/T/review-964.QzsQgI/findings.json

Written by an agent.

[V3RON]

Decision taken

Question (review R3): an operator who set a custom drivers.ios.deviceRoot switches to deviceSet: "default". The leftover check reads only the default own root, so simulators in the custom root are not seen.

Options:

• A. Refuse the switch while the registry holds iOS virtual devices. A user sees iOS off until the registry is clear, whatever root held them. Needs a registry read at driver start (new code path).
• B. Name the old root in the steps: run simlock nuke --delete-devices and simlock doctor --purge-orphans with deviceRoot still set, then remove it and switch. A user sees one more sentence in the steps and docs; no new code.

Taken: B. It keeps the code as specified and is easy to reverse. Missed simulators are not destroyed or touched; their registry records end as device-missing.

Reverting: switch to A by adding a registry check to the driver's start and a Tests line in #968.

Written by an agent.

[V3RON]

Review ledger

Round 1: 971bdb6
Round 2: 246b179
Round fix-check: b8ffd97
Round fix-check: 902059a (CI row-order fix, mechanical, verified by coordinator)

Runs: 7. Cost USD: 1.4777. Agent seconds: 629.
Tokens input 116, output 28029, cache read 1715779, cache write 227186.
- review 1 reviewer: claude-sonnet-5-5 178 s $0.1336
- review 1 spec-reviewer spec: claude-opus-5-5 125 s $0.6487
- fix 1 implementer: claude-sonnet-5-5 58 s $0.1052
- review 2 reviewer: claude-sonnet-5-5 123 s $0.1541
- review 2 spec spec: claude-opus-5-5 55 s $0.2665
- fix 2 implementer: claude-sonnet-5-5 68 s $0.0824
- review fix-check reviewer: claude-sonnet-5-5 22 s $0.0872
Finding outcomes: {"duplicate":1,"fixed":3}. Classes: {"ADR status lists incomplete narrowed sections":1,"binding safety rules 1,7,8,9 left unamended":1,"superseded ADR Status not updated":1,"undecided migration from custom deviceRoot":1}.

{"findings":[
{"id":"R1","role":"spec","class":"binding safety rules 1,7,8,9 left unamended","outcome":"fixed","path":"docs/internal/agent-rules/safety.md","round":"1","fix":"246b1796f7eb8efb6dc90bcaf3ff0481c2c036be"},
{"id":"R2","role":"spec","class":"superseded ADR Status not updated","outcome":"duplicate","canonicalId":"R4","path":"docs/internal/adr/0001-simlock-owned-device-roots.md","round":"1"},
{"id":"R3","role":"spec","class":"undecided migration from custom deviceRoot","outcome":"fixed","path":"docs/internal/adr/0048-an-ios-worker-may-keep-its-simulators-in-xcodes-device-set.md","round":"1","fix":"246b1796f7eb8efb6dc90bcaf3ff0481c2c036be"},
{"id":"R4","role":"spec","class":"ADR status lists incomplete narrowed sections","outcome":"fixed","path":"docs/internal/adr/0001-simlock-owned-device-roots.md","round":"2","fix":"b8ffd9758c8bdc43bc75c76fdc008df20bfcb6aa"}]}

Written by an agent.

[V3RON]

Review notes

Not blocking, not verified. Each is one reviewer's claim.

• spec: docs/internal/adr/0048-an-ios-worker-may-keep-its-simulators-in-xcodes-device-set.md:48 the custom-deviceRoot cleanup steps are shown to no operator (task iOS simulators can live in Xcode's device set (drivers.ios.deviceSet) #968 puts them on the build-and-run page).
• spec: docs/internal/agent-rules/safety.md:112 "Never fall back to the default device location" can read as forbidding the default setting; say it applies only after a failed validation.

Written by an agent.