Repository navigation
chore(agents): process review 2026-10-25: turbo, bug:new triage, feature auto-close, orchestrator scripts, tool-guard waiting rules - #993
Merged
Conversation
…d the decisions taken
…t changed A warm pnpm run build with nothing changed took 15 s and every test:console or test:e2e paid it; it is 2 s now, and one changed src/ file rebuilds the daemon alone (5 s).
…, the orchestrator's hand steps become scripts, and the tool guard breaks the polling chain - delivery rules 1, 8, 9: an agent triages bug:new and stops; the issue-state workflow closes a feature when its last sub-issue closes and closes its request in the same job - issue-body.mjs, review-ledger.mjs, pr-shas.sh; ci-triage.mjs exits 3 on a stale run and prints a failed job's log lines; merge-pr.sh prints a progress line per poll; the deliver skill names each where it replaces a hand-built step - tool-guard.mjs refuses, for a sub-agent, a test run without timeout, a background job, a loop that sleeps, a bare cat > file, and the whole console lane; the slow lane is exempt - the ADR status flip rides in the stack as one fix run before the gate
…; the rules-to-lints scout report
…ver-run rule, and its tests pass the timeout a test run needs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process review of every delivery and spec run since #904, with an adversary pass, and the decisions it led to.
docs/internal/PROCESS-REVIEW-2026-10-25.mdand the rules-to-lints scout report with verdicts.pnpm run buildwith nothing changed goes from 15 s to 2 s.bug:newis the triage queue (bug:triageis gone); the issue-state workflow closes a feature when its last sub-issue closes and closes its request in the same job.issue-body.mjs,review-ledger.mjs,pr-shas.sh;ci-triage.mjsexits 3 on a stale run;merge-pr.shprints progress.timeout, a background job, a loop that sleeps, a barecat > fileand the whole console lane; the slow lane is exempt.After merge: relabel #981 and #264 to
bug:new; delete thebug:triageandbug:triagedlabels.Review
Spec review: skipped. Code review: skipped. Claims review: skipped.
Rounds: 0. Tokens: n/a.
Maintainer-directed process change: merged on green CI by the maintainer's instruction, no review round.
Written by an agent.