Skip to content

CALUNGA-268: Increase builder build-container resources from 4.6cpu/8…#288

Merged
jvulgan merged 2 commits into
calungaproject:mainfrom
rhopp:CALUNGA-268
May 14, 2026
Merged

CALUNGA-268: Increase builder build-container resources from 4.6cpu/8…#288
jvulgan merged 2 commits into
calungaproject:mainfrom
rhopp:CALUNGA-268

Conversation

@rhopp
Copy link
Copy Markdown
Contributor

@rhopp rhopp commented May 14, 2026

…Gi to 8cpu/12Gi and pipeline timeout from 2h to 3h

Summary by Sourcery

Increase Tekton plumbing builder pipelines resource allocation and execution timeout for container build steps.

Build:

  • Raise pipeline timeout to 3 hours for plumbing-builder pull request and push Tekton pipelines.
  • Increase CPU and memory requests/limits for the build-container step in plumbing-builder pull request and push Tekton pipelines to 8 CPU and 12Gi RAM.

…Gi to 8cpu/12Gi and pipeline timeout from 2h to 3h

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 14, 2026

Reviewer's Guide

This PR increases the Tekton plumbing-builder pipeline robustness by extending the overall pipeline timeout to 3 hours and explicitly allocating higher CPU/memory resources (8 CPU / 12Gi) to the build step of the build-container task in both pull-request and push pipelines.

Flow diagram for updated Tekton plumbing-builder pipelines (timeout and resources)

flowchart TD
  GitPR[Git pull_request event]
  GitPush[Git push event]

  GitPR --> PRPipeline[plumbing-builder-pull-request pipeline]
  GitPush --> PushPipeline[plumbing-builder-push pipeline]

  PRPipeline --> PRBuildTask[build-container task]
  PushPipeline --> PushBuildTask[build-container task]

  PRBuildTask --> PRBuildStep[build step\nresources: 8cpu / 12Gi\npipeline timeout: 3h]
  PushBuildTask --> PushBuildStep[build step\nresources: 8cpu / 12Gi\npipeline timeout: 3h]
Loading

File-Level Changes

Change Details Files
Extend pipeline timeout to 3 hours for both plumbing-builder pull-request and push Tekton pipelines.
  • Add a timeouts section to the pipeline spec.
  • Set the pipeline timeout value from the implicit/default 2h to 3h.
.tekton/plumbing-builder-pull-request.yaml
.tekton/plumbing-builder-push.yaml
Increase compute resources for the build step of the build-container task in both pipelines.
  • Introduce taskRunSpecs for the build-container pipeline task.
  • Define a stepSpec for the build step with explicit computeResources.
  • Set both requests and limits to 8 CPU and 12Gi memory for the build step.
.tekton/plumbing-builder-pull-request.yaml
.tekton/plumbing-builder-push.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The same timeout and computeResources configuration is duplicated in both the pull-request and push pipeline YAMLs; consider factoring this into a shared template or overlay if your Tekton setup supports it to reduce drift risk.
  • You’ve set CPU and memory requests equal to limits (8 CPU / 12Gi); if you expect bursty builds or want to avoid potential throttling, consider lowering requests relative to limits or documenting the rationale for using guaranteed QoS here.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The same timeout and computeResources configuration is duplicated in both the pull-request and push pipeline YAMLs; consider factoring this into a shared template or overlay if your Tekton setup supports it to reduce drift risk.
- You’ve set CPU and memory requests equal to limits (8 CPU / 12Gi); if you expect bursty builds or want to avoid potential throttling, consider lowering requests relative to limits or documenting the rationale for using guaranteed QoS here.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jvulgan
Copy link
Copy Markdown
Contributor

jvulgan commented May 14, 2026

/ok-to-test

…to 3h

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jvulgan
Copy link
Copy Markdown
Contributor

jvulgan commented May 14, 2026

/ok-to-test

Copy link
Copy Markdown

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jvulgan jvulgan merged commit 8892a67 into calungaproject:main May 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants