Improve push-py-pulp error handling and upload visibility#291
Merged
Conversation
- Add --disable-progress-bar to twine upload to reduce log noise in CI - Track upload outcomes (uploaded, skipped, failed) and print a summary at the end of the task for quick at-a-glance results - Fail the task with exit code 1 when any upload fails, preventing silent failures where the task reports success despite failed uploads Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefines the pulp-upload helper script’s interaction with twine to reduce CI log noise, make per-file upload results explicit, and ensure the overall task fails when any distribution upload fails. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
Author
|
@jvulgan ptal, I added the failure at the end so that we get visibility into what was uploaded, skipped, and failed before failing the task. |
jvulgan
reviewed
May 19, 2026
jvulgan
reviewed
May 19, 2026
Contributor
jvulgan
left a comment
There was a problem hiding this comment.
lgtm. just squash the commits and also add to the commit body that we're failing the task not only for failed uploads but also for those that are missing atts
- Add --disable-progress-bar to twine upload to reduce log noise in CI
- Track upload outcomes (uploaded, skipped, failed) and print a summary
at the end of the task for quick at-a-glance results
- Fail the task (exit 1) when uploads fail or when files are missing
attestations, preventing silent failures
Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
@ronnll you forgot to squash the commits. I'm not a big fan of force pushing to main to fix it so I guess there's not much we can do now but please next time pay more attention |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Claude Opus 4.6 noreply@anthropic.com
Summary by Sourcery
Improve the pulp-upload script’s package upload reporting and robustness.
New Features:
Bug Fixes:
Enhancements: