Skip to content

Improve push-py-pulp error handling and upload visibility#291

Merged
ronnll merged 2 commits into
mainfrom
CALUNGA-261
May 20, 2026
Merged

Improve push-py-pulp error handling and upload visibility#291
ronnll merged 2 commits into
mainfrom
CALUNGA-261

Conversation

@ronnll
Copy link
Copy Markdown
Contributor

@ronnll ronnll commented May 19, 2026

  • Add --disable-progress-bar to twine upload to reduce log noise in CI
  • Track upload outcomes (uploaded, skipped, failed) and print a summary at the end of the task for quick at-a-glance results
  • Fail the task with exit code 1 when any upload fails, preventing silent failures where the task reports success despite failed uploads

Assisted-by: Claude Opus 4.6 noreply@anthropic.com

Summary by Sourcery

Improve the pulp-upload script’s package upload reporting and robustness.

New Features:

  • Add a summary of upload outcomes (uploaded, skipped, failed) at the end of the pulp-upload task for quick visibility.

Bug Fixes:

  • Ensure the pulp-upload task exits with a non-zero status when any upload fails to avoid silent failures.

Enhancements:

  • Silence the progress bar in twine uploads during CI to reduce log noise.

- Add --disable-progress-bar to twine upload to reduce log noise in CI
- Track upload outcomes (uploaded, skipped, failed) and print a summary
  at the end of the task for quick at-a-glance results
- Fail the task with exit code 1 when any upload fails, preventing
  silent failures where the task reports success despite failed uploads

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 19, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refines the pulp-upload helper script’s interaction with twine to reduce CI log noise, make per-file upload results explicit, and ensure the overall task fails when any distribution upload fails.

File-Level Changes

Change Details Files
Improve twine upload invocation to minimize noisy progress output in CI.
  • Add a command-line flag to disable the progress bar in twine upload invocations
  • Ensure the new flag is applied consistently to all upload calls within the script
utils/scripts/pulp-upload
Introduce explicit tracking and reporting of upload outcomes.
  • Track per-distribution upload status as uploaded, skipped, or failed
  • Aggregate all results and print a concise summary section after processing all uploads
  • Ensure summary output is suitable for quick at-a-glance inspection in CI logs
utils/scripts/pulp-upload
Tighten error handling so the script exits with failure when any upload fails.
  • Detect if any upload operation returns a failure condition
  • Propagate failure by exiting the script with a non-zero status code when there are failed uploads
  • Avoid previous behavior where uploads could fail while the overall task still reported success
utils/scripts/pulp-upload

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ronnll
Copy link
Copy Markdown
Contributor Author

ronnll commented May 19, 2026

@jvulgan ptal, I added the failure at the end so that we get visibility into what was uploaded, skipped, and failed before failing the task.

Comment thread utils/scripts/pulp-upload Outdated
@ronnll ronnll requested a review from jvulgan May 19, 2026 14:54
Copy link
Copy Markdown
Contributor

@jvulgan jvulgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just squash the commits and also add to the commit body that we're failing the task not only for failed uploads but also for those that are missing atts

- Add --disable-progress-bar to twine upload to reduce log noise in CI
- Track upload outcomes (uploaded, skipped, failed) and print a summary
  at the end of the task for quick at-a-glance results
- Fail the task (exit 1) when uploads fail or when files are missing
  attestations, preventing silent failures

    Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
@ronnll ronnll merged commit 6a620c7 into main May 20, 2026
4 checks passed
@ronnll ronnll deleted the CALUNGA-261 branch May 20, 2026 18:37
@jvulgan
Copy link
Copy Markdown
Contributor

jvulgan commented May 21, 2026

@ronnll you forgot to squash the commits. I'm not a big fan of force pushing to main to fix it so I guess there's not much we can do now but please next time pay more attention

@ronnll
Copy link
Copy Markdown
Contributor Author

ronnll commented May 21, 2026

@ronnll you forgot to squash the commits. I'm not a big fan of force pushing to main to fix it so I guess there's not much we can do now but please next time pay more attention

@jvulgan ahh welp, youre right. I usually always do, not sure how I missed this. Will double check in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants