Conversation
…cription case, fix shop test assertions, sort social test reactions
…annelTest require, deterministic reaction ordering
- Remove unreachable error handling in file_uploader.ex (S3 mock always returns ok) - Remove unreachable error clauses in eos.ex unlock_wallet, create_account, netlink, and issue functions (mocks return specific success types) - Remove unreachable error handling in sign_up.ex create_eos_account and invite_user functions - These clauses are unreachable because the test mocks return types that don't match the error patterns
The CI environment preserves additional metadata fields that differ from the local environment. Updated whitelist to include: - ResolutionUnit - XResolution - YResolution These fields are present in the CI test environment and need to be included in the whitelist for the test to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this PR close
Closes #
Changes Proposed ( a list of new changes introduced by this PR)
How to test ( a list of instructions on how to test this PR)