Skip to content

Update dependencies to fix security vulnerabilities - #567

Merged
cameronapak merged 4 commits into
mainfrom
devin/1795089502-security-deps
Nov 19, 2026
Merged

cameronapak merged 4 commits into
mainfrom
devin/1795089502-security-deps

Conversation

@cameronapak

@cameronapak cameronapak commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fixes dependency vulnerabilities found by an OSV lockfile scan across the root app, cli/ (the npm package) and landing/.

osv-scanner 2.7.1, all three lockfiles:

Severity Before After
Critical 6 1
High 75 2
Medium 97 0
Low 20 3
  • Bumped direct deps (vite, shadcn, TanStack router/start in landing, better-auth/@better-auth/stripe to latest 1.6).
  • Added overrides pinning patched transitive versions (hono, undici, @modelcontextprotocol/sdk, qs, body-parser, minimatch, glob, sharp, zod, ...).
  • cli/ and landing/ now scan clean.
  • Root + CLI changesets (patch).

Still open: Better Auth 1.6.35 advisories (GHSA-965c-763c-88jm critical, GHSA-q84f-53jg-9ppm, GHSA-r4xp-prcw-77qf high, GHSA-44jh-23m7-hpcf low). The patched 1.7 line drops the mcp plugin and oAuthDiscoveryMetadata exports the Worker uses, so it needs an MCP OAuth-provider migration; being attempted as a follow-up.

Testing

lint, fmt:check, typecheck, typecheck:worker, build:cf, build:cli + CLI tests (41 pass), landing typecheck/build all pass. bun run test: 6 failures + 1 error that reproduce identically on main (Stripe/unfurl fixture transport, Miniflare hook timeout); those files pass in isolation. cf:dev smoke: / and /api/auth/get-session return 200.


Prune & Cultivate opened this PR for Cameron
Implemented in session Fix security vulnerabilities in dotflowy
Review with Devin · Open in Devin Desktop



Note

Devin could not open this Pull Request as cameronapak: they have no GitHub connection usable for this repository.
As a fallback, Devin opened this PR as itself.

Co-Authored-By: Cameron Pak <cameronandrewpak@gmail.com>
@pullfrog

pullfrog Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Pullfrog  | Review this ➔

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Newer findings are available below. Devin Review posted a newer report on this PR, in addition to the findings presented here.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Comment thread .changeset/secure-dependency-updates.md Resolved
devin-ai-integration Bot and others added 2 commits November 19, 2026 12:32
Co-Authored-By: Cameron Pak <cameronandrewpak@gmail.com>
Co-Authored-By: Cameron Pak <cameronandrewpak@gmail.com>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

⚠️ 1 issue in files not directly in the diff

⚠️ Missing CLI changeset blocks release checks

With new package overrides and no CLI fragment, requiresCliChangeset rejects the PR. The root fragment cannot satisfy the independent CLI Changesets project, so the CLI changeset check fails.

Devin Review

Co-Authored-By: Cameron Pak <cameronandrewpak@gmail.com>
@cameronapak

Copy link
Copy Markdown
Owner Author

Re Devin Review's missing CLI changeset note: fixed in c8de4b8. I removed the overrides from cli/package.json so the published manifest matches main, and kept the patched launch-editor/undici in cli/bun.lock. The CLI changeset check now passes and the CLI OSV scan is still clean.

@cameronapak
cameronapak merged commit a241536 into main Nov 19, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant