Fixed absolute and protocol relative URL cleanup#3
Open
hvesalai wants to merge 1 commit into
Open
Conversation
- fixed url handling when removing protocol or server part:
- only removes protocol and hostname from the beginning of the URL
- handles protocol relative URLS
(previously an URL like "//foo/foo" would have been converted to "///foo")
- fixed module name in error message
- removed dead code and commented-out debug logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(previously an URL like "//foo/foo" would have been converted to "///foo")