Some fixes and a testsuite#4
Open
cobexer wants to merge 3 commits into
Open
Conversation
- routeList is not a local variable in the reset function(setting it there has no effect) - don't overwrite the router object as that breaks router.parameters() to return the exact same object as router.currentParameters
…t to automate currently 79% line coverage (62% branch; 91% function)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just found your plugin and thought it looked useful but could not find tests or extensive documentation so I wrote a testsuite to checkout what this plugin can do.
The first 2 commits are a bugfix and jshint violation fixes - separated out in case you dislike the testsuite(/tooling).
Have fun 😃