Skip to content

Derived module to import bank statements#3

Open
gracinet wants to merge 8 commits into
camptocamp:masterfrom
gracinet:bank-statement
Open

Derived module to import bank statements#3
gracinet wants to merge 8 commits into
camptocamp:masterfrom
gracinet:bank-statement

Conversation

@gracinet

@gracinet gracinet commented Sep 3, 2014

Copy link
Copy Markdown

This module provides a new backend version, that in turns leverages the account_statement_base_import module.

Each chunk becomes a bank statement. Some flexibility is provided through the dedicated configuration fields on the backend model.
For instance, one can decide to cut in chunks of at most 50 lines having a single date, storing that date as the statement's date.

One can also decide to base the statement's name on lines labels if lots of line share the same label (can have special functional meaning). Not leaving the default name is good for concurrency (no sequence involved).

Georges Racinet added 2 commits September 3, 2014 17:36
This gives more flexibility with respect to the parameters that
will be used by the actual methods. For instance, this allows
the CSV policy for bank statements not to override the parse_one() method
@lepistone

Copy link
Copy Markdown
Contributor

Thanks @gracinet! The travis build is red because of a missing OpenERP dependency.

These are handled manually in .travis.yml. Can you please update it?

(see https://github.com/OCA/maintainer-quality-tools#sample-travis-configuration-file-for-version-70)

connector_file_bank_statement needs account-bank-statement-reconcile
@gracinet

gracinet commented Sep 4, 2014

Copy link
Copy Markdown
Author

Done, hope it'll work !

Can you please show me the link to that Travis so that I can see for
myself ?

Thanks

On 09/04/2014 01:50 PM, Leonardo Pistone wrote:

Thanks @gracinet https://github.com/gracinet! The travis build is
red because of a missing OpenERP dependency.

These are handled manually in |.travis.yml|. Can you please update it?

(see
https://github.com/OCA/maintainer-quality-tools#sample-travis-configuration-file-for-version-70)


Reply to this email directly or view it on GitHub
#3 (comment).

@lepistone

Copy link
Copy Markdown
Contributor

@gracinet it's directly on the pull request view, to the side of your commits. I see also a large comment-like box, but that's just because I have commit rights.

thanks!

@gracinet

gracinet commented Sep 4, 2014

Copy link
Copy Markdown
Author

neat, didn't notice, thanks !

Georges Racinet added 5 commits September 4, 2014 17:05
It uses anybox.testing.openerp to load some XML
configuration file (the quickest way for me to produce it)
and it detected that I forgot to set bank_statement_id on
imported chunks.
Forgotten files that should have been with
f946854

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be only on 'done'? If your import failed for a bad configuration of backend like wrong user, you cannot restart it.

@yvaucher

Copy link
Copy Markdown
Contributor

I tested it and it works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants