Skip to content

fix(_cython): disable stale PTA cache reuse in NPU fast add #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lvyufeng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(_cython): disable stale PTA cache reuse in NPU fast add #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/candle/_cython/_npu_ops.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,12 @@ cdef dict _alpha_one_handles = {} # dtype_code -> alpha=1 scalar handle (
cdef dict _alpha_one_bytes_cache = {} # dtype_code -> (bytes, alpha_dtype_code) for PTA hash
cdef object _pta_cache_begin_fn = None # _aclnn_ffi.pta_begin_add_cache_lookup
cdef object _pta_cache_end_fn = None # _aclnn_ffi.pta_end_cache_lookup
# Disabled by default: the PTA cached-executor path can reuse stale bound tensor
# addresses across NPU add calls, which corrupts later view-based adds
# (e.g. a prior x+x can make a later view+ones behave like view+view).
# Keep the integration wired but guarded so it can be re-enabled once the
# cached executor path safely rebinds descriptors/addresses.
cdef bint _use_add_pta_cache = False


cdef inline void _ensure_ffi_binary() except *:
Expand Down Expand Up @@ -516,7 +522,7 @@ def fast_add(a, b):
cdef uintptr_t alpha_handle

# 9. Try PTA executor cache (torch_npu-aligned hit_cache_v2 path)
if _pta_cache_begin_fn is not None:
if _use_add_pta_cache and _pta_cache_begin_fn is not None:
alpha_bytes_pair = _get_alpha_one_bytes(dtype_code)
state = _pta_cache_begin_fn(
py_a_shape, a.stride,
Expand Down
Loading