chore(interfaces): move analytics interface schemas to new format - #660
Open
james-garner-canonical wants to merge 1 commit into
Open
Conversation
…rmat Interface schemas no longer wrap their models in the `ProviderSchema` and `RequirerSchema` classes from `pytest-interface-tester`. Instead a schema names all four databags directly, as `ProviderAppData`, `ProviderUnitData`, `RequirerAppData` and `RequirerUnitData`, setting a databag that is always empty to `None`. Naming all four makes an empty databag a deliberate choice a reviewer can see, and makes a misspelled name an error rather than a silently empty databag. The models are unchanged; only the wrapper classes around them are gone. Dropping the `pytest-interface-tester` import leaves Pydantic as the only dependency needed to read a schema. This also removes the interface test definitions for these interfaces. The interface tests are being retired; the tooling that ran them is removed separately. A follow-up PR documents the format and adds a CI check for it, once every interface has been migrated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
james-garner-canonical
marked this pull request as ready for review
September 3, 2026 06:01
james-garner-canonical
force-pushed
the
26-08+chore+interface-schemas-analytics
branch
from
September 11, 2026 03:10
7a77517 to
2b648d8
Compare
|
Since this has to do with Velero, @dariofaccin could you please take a quick look? The changes looks sane. The only bit is the removal of the tests, but I suppose it is related to the fact that |
Collaborator
Author
Yes, exactly, this type of interface test wasn't widely adopted and we're moving away from them now. |
deusebio
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
pytest-interface-testerwrappers in the schema with a new convention: naming all four databags directly, asProviderAppData,ProviderUnitData,RequirerAppDataandRequirerUnitData, setting a databag that is always empty toNone.A follow up PR will document this and add tooling to enforce it, after similar PRs have landed for all the other
CODEOWNERSin this repository.Only the latest version of each schema is updated. We plan to flatten the interface definitions in future to no longer store old versions, and only validate and document the current version.
This PR also removes the interface test definitions for these interfaces. The interface tests are being retired; the tooling that ran them is being removed separately.