test: opt rollingops and nginx_k8s in to warnings-as-errors - #672
Open
tonyandrewmeyer wants to merge 1 commit into
Open
tonyandrewmeyer wants to merge 1 commit into
tonyandrewmeyer wants to merge 1 commit into
Conversation
These were the two packages left out when the rest of the repo opted in. Both needed a fix first. rollingops was resolving ops 3.6.0, which leaks a finalizer on teardown; bumping the lock to 3.8.2 clears it, the same way it did for the other packages. nginx_k8s leaks the file that _has_config_changed pulls from the container, because the result of Container.pull is read and then dropped. Close it. Refs canonical#519 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PM2tqGcK4mYRFF4WU5uBXn
tonyandrewmeyer
marked this pull request as ready for review
September 10, 2026 06:34
patriciareinoso
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are two packages that were left out when the rest of the repo opted in to warnings-as-errors, and each needed a fix first.
rollingopswas resolving ops 3.6.0 in its own lock, which leaks a finalizer on teardown, so six tests failed withPytestUnraisableExceptionWarning. Bumping the lock to 3.8.2 clears it, the same way it did for the other packages before test: opt six packages in to warnings-as-errors #612 merged.nginx_k8swas on ops 3.2.0, and bumping that left one genuine failure:_has_config_changedreads the result ofContainer.pulland then drops it, so the file is never closed. Closing it is what ops' own docs now tell you to do, and thewithform works back to ops 3.0, so theops>=3floor is fine as it stands.Refs #519