test(tls-certificates): flat layout for test charms, minor doc fixes/improvements - #673
Open
james-garner-canonical wants to merge 2 commits into
Conversation
james-garner-canonical
force-pushed
the
26-09+tmp+reorg-integration-test-charms
branch
from
September 7, 2026 00:19
af24e4a to
c46e8a0
Compare
Comment on lines
+1
to
+8
| # Placeholder README for the library under test | ||
|
|
||
| This directory is a local copy of the library under test. Test charms depend on it by creating a symlink to it and pointing their `tool.uv.sources` there. | ||
|
|
||
| We need this local copy rather than just symlinking to the parent library directory so that when we `cp --recursive --dereference` the test charm to prepare it for packing, the library symlink is not recursive. | ||
|
|
||
| - `pyproject.toml` and `src/` are symlinks to the real library at the package root so the charm always builds against the current source. | ||
| - `README.md` is this placeholder. A readme is required because the library decalares `readme = "README.md", and hatchling fails the build if that file is missing. No newline at end of file |
Collaborator
Author
There was a problem hiding this comment.
The placeholder readme.
james-garner-canonical
marked this pull request as ready for review
September 7, 2026 01:26
saltiyazan
approved these changes
Sep 14, 2026
saltiyazan
left a comment
saltiyazan
left a comment
Contributor
There was a problem hiding this comment.
Looks all good. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rearranges the layout of the local charms defined for integration tests, to use a flat rather than nested layout. You can see the new layout in my branch, and the old nested layout on main.
I think this layout is a bit more user friendly, and makes it more obvious what's actually going on. The library template still lacks this kind of infrastructure for interface libraries (it just scaffolds a single test charm), and I'm thinking about using this layout for it. Keen to hear if you think it's an improvement.
Also:
README.mdin local library copy with placeholder that documents why it's needed.pack.sh.