Makefile: fix version script #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors the fix in canonical#127 but for the target filename instead of for the version scriptlet. The current `usr/lib/snapd/info` looks like this: ``` VERSION=2.59.3 SNAPD_APPARMOR_REEXEC=1 SNAPD_ASSERTS_FORMATS='{"snap-declaration":5,"system-user":2}' ``` which means that the previous version of the code would extract a version number like: ``` $ cat usr/lib/snapd/info|cut -f2 -d=|cut -f1 -d~|cut -b1-29 2.59.3 1 '{"snap-declaration":5,"syste ``` Using `grep` to just find the right lines fixes this. This was observed in recent uploads of core, e.g. in https://launchpad.net/~snappy-dev/+snap/core-beta/+build/2098563 Thanks to Colin and Dimitri for their help with this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the fix in #127 but for the target filename instead of for the version scriptlet.
The current
usr/lib/snapd/infolooks like this:which means that the previous version of the code would extract a version number like:
Using
grepto just find the right lines fixes this.This was observed in recent uploads of core, e.g. in https://launchpad.net/~snappy-dev/+snap/core-beta/+build/2098563
Thanks to Colin and Dimitri for their help with this!