Skip to content

static/writable-paths: set safer options for tmpfs mounts #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alfonsosanchezbeato wants to merge 2 commits into
base: master
Choose a base branch
from
Open

static/writable-paths: set safer options for tmpfs mounts #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af387ce
static/writable-paths: set safer options for tmpfs mounts
alfonsosanchezbeato Nov 26, 2021
8135c9a
tests/basic: check options for tmpfs
alfonsosanchezbeato Nov 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions static/etc/system-image/writable-paths
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
# snap data
/var/snap auto persistent transition none
# generic
/media none temporary none defaults
/mnt none temporary none defaults
/media none temporary none mode=1777,strictatime,nosuid,nodev
Copy link
Copy Markdown
Contributor

@mvo5 mvo5 Nov 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need mode=1777 for /mnt and /media ? Those are not really dirs that have the same semantic as /tmp, they are more dirs with a similar semantic as /run AIUI. Or is there soemthing I'm missing here?

Copy link
Copy Markdown
Member Author

@alfonsosanchezbeato alfonsosanchezbeato Nov 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this change, when I run stat on /mnt and /media it actually shows mode 1777 already, so I think that is the default mode. This just shows that more explicitly. So we can remove it I guess, I do not have a strong opinion either way.

/mnt none temporary none mode=1777,strictatime,nosuid,nodev
/root auto persistent transition none
/tmp none temporary none defaults
/tmp none temporary none mode=1777,strictatime,nosuid,nodev
/var/tmp auto persistent transition none
# etc related
/etc/writable auto persistent transition none
Expand Down
6 changes: 6 additions & 0 deletions tests/spread/basic/task.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,9 @@ execute: |
# Verify system services are running
execute_remote systemctl -q is-active snapd
execute_remote snap change 1

# Check tmpfs mount options are as expected
execute_remote grep -e 'tmpfs /tmp .*nosuid,nodev.*' /proc/mounts
execute_remote grep -e 'tmpfs /media .*nosuid,nodev.*' /proc/mounts
execute_remote grep -e 'tmpfs /mnt .*nosuid,nodev.*' /proc/mounts
execute_remote grep -e 'tmpfs /var/lib/sudo .*nosuid,nodev,mode=700.*' /proc/mounts