Conversation
uses the official pySigma library to validate sigma rules in SigmaRules.add(), which is used for by public methods for loading sigma rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Prior to this PR, sigma rules were loaded but not validated
Solution
Uses the official pySigma library to validate sigma rules in SigmaRules.add(), which is used by all public methods for loading sigma rules
Checklist
project.versionfield in thepyproject.tomlfile.Context
See #197, #196 , and #195
Testing Instructions
Run the added unit tests (
tox run -e unit)Upgrade Notes
NA