Skip to content

feat: Alert Knob #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sinapah wants to merge 6 commits into
base: main
Choose a base branch
from
+1,014 −90
Open

feat: Alert Knob #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7d0cbb
feat: Alert Knob
sinapah Aug 24, 2026
5666488
fix: make test YAML configs formatter-agnostic across black versions
sinapah Aug 24, 2026
58f74d5
feat: bump version
sinapah Aug 24, 2026
637ee1d
fix: remove all addition related logic
sinapah Aug 25, 2026
38dfe0c
fix: lint
sinapah Aug 25, 2026
02ef0b6
feat: alert knob using pydantic (#207)
sinapah Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "hatchling.build"

[project]
name = "cosl"
version = "1.10.3"
version = "1.11.3"
authors = [
{ name = "sed-i", email = "82407168+sed-i@users.noreply.github.com" },
]
Expand Down Expand Up @@ -123,3 +123,8 @@ ignore-words-list = "assertIn"
[tool.hatch.metadata]
# allow git+ dependencies in pyproject
allow-direct-references = true

[dependency-groups]
test = [
"pytest>=8.3.5",
]
3 changes: 3 additions & 0 deletions src/cosl/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from .juju_topology import JujuTopology
from .mandatory_relation_pairs import MandatoryRelationPairs
from .rules import AlertRules, RecordingRules
from .rules_customization import AlertRulesCustomization, AlertRulesCustomizationError
from .types import type_convert_stored

__all__ = [
Expand All @@ -18,6 +19,8 @@
"DashboardPath40UID",
"AlertRules",
"RecordingRules",
"AlertRulesCustomization",
"AlertRulesCustomizationError",
Comment on lines +22 to +23

@sinapah sinapah Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at canonical/prometheus-k8s-operator#857 to see how these are intended to be used.

"MandatoryRelationPairs",
"type_convert_stored",
]
Loading
Loading