feat(rockcraft/pack): migrate to Node24 - #59
Conversation
a182cd4 to
74b566f
Compare
There was a problem hiding this comment.
Overall looks good to me. thanks!
There are a couple of changes that are not strictly related to the node24 update (unused variables, object declarations), though really minor, so all good.
My only concern is regarding the modification of eslint rules. See below:
swap the rocks build job's rockcraft-pack from canonical/craft-actions@main to the fork branch in canonical/craft-actions#59 (node24 migration), to clear the node20 deprecation warning. revert to canonical@main once that PR merges.
lczyk
left a comment
lczyk
left a comment
There was a problem hiding this comment.
looks great. run the tests locally and confirmed all works fine. also tested it in a personal project and it works great there too. a couple of drive-bys but all justifiable and simple. after some investigation i concur with the "crazy typing of fs.promises.readdir()" and the decay to any is completely warranted imo
strong +1. we should really get this merged before github actions stop working...
bepri
left a comment
bepri
left a comment
There was a problem hiding this comment.
Thanks for taking this on! Always a fan of modernization.
node24 migration (canonical/craft-actions#59) merged upstream, so drop the fork-branch trial and point back at canonical/craft-actions/rockcraft-pack@main.
swap the rocks build job's rockcraft-pack from canonical/craft-actions@main to the fork branch in canonical/craft-actions#59 (node24 migration), to clear the node20 deprecation warning. revert to canonical@main once that PR merges.
node24 migration (canonical/craft-actions#59) merged upstream, so drop the fork-branch trial and point back at canonical/craft-actions/rockcraft-pack@main.
5 participants
This PR updates actions to support Node24.
fs.Stats(): constructor is now privatefs.Dirent(in particularreaddir): TS uses the most specific overload available afterspyOnresolution, which expectsDirent<NonSharedBuffer>[]and notstring[]as in Node18.