Skip to content

Improve checks on _promote_charms action #369

Description

@zmraul

When passing a list of tags to promote, the workflow should make sure that all revision tags are present on the target commit. So no revision is left behind when promoting.

Trying to promote a revision that already exists on the target track is a no-op from charmcraft, so there is no problem on passing a complete list multiple times. Two different things are solved by checking this:

  • If a failure happens mid promotion loop, we can pass the full list again. Any revision that was promoted will no-op and the loop will continue until the failure point and keep going.
  • We avoid having an incomplete promotion being triggered by automated runs.

Extra reference: #366 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions