Skip to content

patch(_promote_snaps.yaml): Fix risk comparison #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sinclert-canonical merged 2 commits into from
Jul 27, 2026
Merged

patch(_promote_snaps.yaml): Fix risk comparison #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92e9182
Fix promote-snaps missing LT
sinclert-canonical Jul 24, 2026
8446761
Add promote-snaps to README file
sinclert-canonical Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
| [_promote_charms.yaml](.github/workflows/_promote_charms.md) | **Experimental** Promote charms by revision & generate release notes |
| [_promote_charm_legacy_1.yaml](.github/workflows/_promote_charm_legacy_1.md) | **Deprecated** `charmcraft promote` & generate release notes for charm without refresh compatibility version tags |
| [_promote_charms_legacy_2.yaml](.github/workflows/_promote_charms_legacy_2.md) | **Deprecated** `charmcraft promote` & generate release notes |
| [_promote_snaps.yaml](.github/workflows/_promote_snaps.md) | **Experimental** `snapcraft promote` & generate release notes |
| [check_charm_pr.yaml](.github/workflows/check_charm_pr.md) | Check charm pull request has required labels for release notes |
| [approve_renovate_pr.yaml](.github/workflows/approve_renovate_pr.md) | Reduce required approvals on [Renovate](https://docs.renovatebot.com/) pull requests by 1 |
| [_update_bundle.yaml](.github/workflows/_update_bundle.md) | **Experimental** Update charm revisions in bundle |
Expand Down Expand Up @@ -71,4 +72,3 @@ Workflows that begin with two underscores (e.g. `__foo.yaml`) are for this repos

Data Platform Workflows is covered by the [Ubuntu Code of
Conduct](https://ubuntu.com/community/ethos/code-of-conduct).

6 changes: 6 additions & 0 deletions _cli/data_platform_workflows_cli/craft_tools/promote_snaps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ def get(cls, value, *, direction: Direction): # Cannot override __call__ or __n
)
return cls(value)

def __lt__(self, other):
if not isinstance(other, Risk):
raise TypeError
order = list(Risk)
return order.index(self) < order.index(other)


def get_snap_revisions(channel_name: str, snap_name: str, tag_prefix: str, raise_missing: bool):
"""Get the current snap revisions in the target channel."""
Expand Down