Skip to content

fix(promote-charms): verify all revision tags on target commit are provided #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xhon-pelushi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(promote-charms): verify all revision tags on target commit are provided #381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions _cli/data_platform_workflows_cli/craft_tools/promote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,28 @@ def charms():
commit_sha = commit_shas.pop()
logging.info(f"All provided revisions were built from git commit {repr(commit_sha)}")

# Verify that no revision tags pointing at this commit were left out of the `revisions` input
# (e.g. an amd64 revision tag provided but the arm64 revision tag for the same commit is not),
# so that a partial promotion cannot be triggered by mistake
logging.info("Checking that all revision tags on the target commit were provided")
missing_tags: list[str] = []
for charm, revisions in charm_revisions_map.items():
tags_on_commit = subprocess.run(
["git", "tag", "--list", f"{charm.tag_prefix}*", "--points-at", commit_sha],
capture_output=True,
check=True,
text=True,
).stdout.splitlines()
provided_tags = {f"{charm.tag_prefix}{revision}" for revision in revisions}
missing_tags.extend(sorted(set(tags_on_commit) - provided_tags))
if missing_tags:
raise ValueError(
f"Revision tag(s) {repr(sorted(missing_tags))} point to the same git commit "
f"({repr(commit_sha)}) as the provided `revisions` input but were not included in it. "
"Include all revision tags for this commit so that no revision is left behind when "
"promoting."
)

subprocess.run(["git", "checkout", commit_sha], check=True)

for charm in charms_:
Expand Down