chore: backport ambient changes to track/2.4 - #206
Merged
Merged
Conversation
Closes #187 1. Adds relation handling for the `service-mesh` and `istio-ingress-route` relations 2. Removed the old `IngressRelationWarnIfMissing ` component that was checking if the `ingress` relation was not established 3. Created a new `IstioRelationsConflictDetector` component that puts the charm to blocked state if both `ingress` and `istio-ingress-route` relation are established at the same time (NOTE: this could easily be a common component) 4. Created a copy of the Integration tests named `test_charm_ambient.py` For now the integration tests are not checking something ambient specific, as here envoy is just a proxy. Will need to revisit this particular case (since there's no connected UI to check if the requests go to)
* chore: update terraform outputs to include ambient mesh relations * fix: use jlumbroso/free-disk-space action
github-actions
Bot
added
the
Libraries: Out of sync
NohaIhab
marked this pull request as ready for review
April 27, 2026 13:11
Contributor
|
LGTM, tests using ambient has passed here |
deusebio
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of canonical/bundle-kubeflow#1398