Skip to content

fix: use 443 for tls - #212

Merged
NohaIhab merged 2 commits into
mainfrom
kf-8724/fix-use-443-for-tls
Jun 10, 2026
Merged

NohaIhab merged 2 commits into
mainfrom
kf-8724/fix-use-443-for-tls

Conversation

@NohaIhab

@NohaIhab NohaIhab commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Part of canonical/bundle-kubeflow#1441

Changes

  • Set the ingress listener port to 443 when ingress.tls_enabled, else 80.
  • Add a parametrized unit test covering both the TLS-enabled (443) and TLS-disabled (80) cases.
  • Remove unused pytest-lazy-fixture dependency (incompatible with pytest 8) and refresh poetry.lock.

@ckfbot ckfbot added the backport track/2.4 Backport to track/2.4 label Jun 9, 2026
@ckfbot

ckfbot commented Jun 9, 2026

Copy link
Copy Markdown

🤖 Backport labels populated

Labels to this pull request were added automatically by the populate-labels.yaml action.

When the PR is merged, backport PRs according to the labels will be automatically created. To skip the backport creation, remove any unneeded labels before merging the PR.

@NohaIhab
NohaIhab requested a review from a team June 9, 2026 11:47
@dariofaccin
dariofaccin requested a review from a team June 9, 2026 12:55
@NohaIhab
NohaIhab merged commit 6f23f3a into main Jun 10, 2026
12 checks passed
@NohaIhab
NohaIhab deleted the kf-8724/fix-use-443-for-tls branch June 10, 2026 11:08
@ckfbot

ckfbot commented Jun 10, 2026

Copy link
Copy Markdown

Successfully created backport PR for track/2.4:

NohaIhab added a commit that referenced this pull request Jun 10, 2026
* fix: use 443 for tls

(cherry picked from commit 6f23f3a)

Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport track/2.4 Backport to track/2.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants