Skip to content

Refactored the test - #646

Open
minulo wants to merge 7 commits into
mainfrom
feat/get-proxied-endpoint-action-refactor
Open

Refactored the test#646
minulo wants to merge 7 commits into
mainfrom
feat/get-proxied-endpoint-action-refactor

Conversation

@minulo

@minulo minulo commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

What this PR does

Refactored the get-proxied-endpoints Juju action tests so that it fits

Why we need it

To ensure all the tests in the code base follow the same style

Checklist

  • I followed the contributing guide
  • I added or updated the documentation (if applicable)
  • I updated docs/changelog.md with user-relevant changes
  • I added a change artifact for user-relevant changes in docs/release-notes/artifacts. If no change artifact is necessary, I tagged the PR with the label no-release-note.
  • I used AI to assist with preparing this PR
  • I added or updated tests as needed (unit and integration)
  • If integration test modules are used: I updated the workflow configuration
    (e.g., in .github/workflows/integration_tests.yaml, ensure the modules list is correct)
  • If this PR involves a Grafana dashboard: I added a screenshot of the dashboard
  • If this PR involves Terraform: terraform fmt passes and tflint reports no errors

Co-authored-by: minulo <292215651+minulo@users.noreply.github.com>
Co-authored-by: minulo <292215651+minulo@users.noreply.github.com>

Copilot AI commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@copilot I just did git pull. Can you cjeck on the get_proxied_endpoints_with_backend_filter_non_existing_backend before any our changes vs after? Our aseert conmments aint adding up with what is curr...

Before and after the PR, this test asserted {"endpoints": "[]"}; the refactor did not change that behavior or assertion. The action implementation filters unmatched backends and always sets JSON results, so it returns an empty list rather than raising ActionFailed. The stale part is the docstring’s assert: raises ActionFailed text; the assertion and actual code are consistent.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Libraries: OK no-release-note This PR does not require a change artifact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants