Skip to content

fix: charmcraft fetch-lib - #506

Merged
gabrielcocenza merged 2 commits into
canonical:mainfrom
MichaelThamm:fix/fetch-lib
Mar 4, 2026
Merged

gabrielcocenza merged 2 commits into
canonical:mainfrom
MichaelThamm:fix/fetch-lib

Conversation

@MichaelThamm

@MichaelThamm MichaelThamm commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

cos_agent had a breaking change. Fixed in 0.25. See details here and the PR here.

Fixed with charmcraft fetch-lib.

@MichaelThamm

Copy link
Copy Markdown
Contributor Author

Ping @gabrielcocenza. Can I get a review please?

@jneo8 jneo8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MichaelThamm for the fix!

I’d like to limit the changes strictly to cos_agent to avoid any unexpected issues in production. Could you update the library using the command charmcraft fetch-lib charms.grafana_agent.v0.cos_agent?

@MichaelThamm

Copy link
Copy Markdown
Contributor Author

Not sure why, but GH says it is still processing updates ... I think I will close this PR and create a new one

@MichaelThamm MichaelThamm reopened this Mar 3, 2026
@MichaelThamm

MichaelThamm commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

Oh nice, closing the PR and re-opening it fixed it ... Thanks GH 😅

Another review please @jneo8. Can you please rerun the failing CI? It hit a timeout

@gabrielcocenza

Copy link
Copy Markdown
Member

Hi @MichaelThamm I have previously opened a PR for this to change HWO to otel: #504

I think we can close this one and I'll check tomorrow if the issue is fixed.

Sorry for the delay

@jneo8 jneo8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MichaelThamm

@jneo8

jneo8 commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Hi @gabrielcocenza, do you think we’re good to move forward with this merge? The changes seem accurate and low-risk to me, but I wanted to get your final thoughts. And yes you may need to fetch & rebase after.

@gabrielcocenza
gabrielcocenza merged commit bc9d3df into canonical:main Mar 4, 2026
29 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants