fix: charmcraft fetch-lib - #506
Conversation
|
Ping @gabrielcocenza. Can I get a review please? |
There was a problem hiding this comment.
Thanks @MichaelThamm for the fix!
I’d like to limit the changes strictly to cos_agent to avoid any unexpected issues in production. Could you update the library using the command charmcraft fetch-lib charms.grafana_agent.v0.cos_agent?
|
Not sure why, but GH says it is still processing updates ... I think I will close this PR and create a new one |
|
Oh nice, closing the PR and re-opening it fixed it ... Thanks GH 😅 Another review please @jneo8. Can you please rerun the failing CI? It hit a timeout |
|
Hi @MichaelThamm I have previously opened a PR for this to change HWO to otel: #504 I think we can close this one and I'll check tomorrow if the issue is fixed. Sorry for the delay |
|
Hi @gabrielcocenza, do you think we’re good to move forward with this merge? The changes seem accurate and low-risk to me, but I wanted to get your final thoughts. And yes you may need to fetch & rebase after. |
cos_agenthad a breaking change. Fixed in0.25. See details here and the PR here.Fixed with
charmcraft fetch-lib.