Skip to content

feat: Update manifests to match upstream kfp 2.16.0 release - #870

Merged
mvlassis merged 71 commits into
mainfrom
kf-8571-upgrade-manifests
Apr 30, 2026
Merged

mvlassis merged 71 commits into
mainfrom
kf-8571-upgrade-manifests

Conversation

@mvlassis

@mvlassis mvlassis commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Ref: #869

This PR updates the charms according to the update to the manifests files corresponding to the 2.16.0 release of Kubeflow pipelines. This task is part of the team's upgrade to Kubeflow 26.03.

The diff between the 2 versions was generated by following the instructions on the upstream README. It can be found here.

Notes

@github-actions github-actions Bot added the Libraries: Out of sync The charm libs used are out-of-sync label Apr 2, 2026
@mvlassis mvlassis changed the title feat: Update manifests to match upstream 2.16.0 release feat: Update manifests to match upstream kfp 2.16.0 release Apr 2, 2026
@mvlassis
mvlassis requested review from MattiaSarti, NohaIhab and misohu and removed request for misohu April 2, 2026 10:28
@mvlassis

mvlassis commented Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

After discussing with @misohu, we:

  • Try to create the same bucket that apiserver needs, in order to avoid creating unnecessary buckets.
  • Defer the event in case the object storage is not reachable. This follows the good practices for deferring an event, since the error should only be temporary (during startup of minio). We prefer not to defer on reconciler patterns, so we just wait until the next event is triggered to put the status to "active".

@misohu misohu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait we never defer in our charms we use update status

@NohaIhab NohaIhab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mvlassis, some comments and questions for me to understand

Comment thread charms/kfp-api/src/charm.py
Comment thread charms/kfp-api/src/charm.py Outdated
Comment thread charms/kfp-api/poetry.lock
Comment thread charms/kfp-api/metadata.yaml
Comment thread charms/kfp-profile-controller/tests/integration/test_charm.py
Comment thread charms/kfp-profile-controller/files/upstream/sync.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Libraries: Out of sync The charm libs used are out-of-sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants