Skip to content

Updating the KFAM port and manager-port through the config doesn't work #116

Description

@phoevos

Although port and manager-port are configured correctly on install, they can't be tweaked by updating the config.

This is due to the fact that KubernetesServicePatch, which we use for patching the underlying K8s Service, does not observe config-changed events by default (only install, upgrade-charm, and update-status).

Solution

  • Explicitly add config-changed to the list of observed events using the refresh_event argument when initialising KubernetesServicePatch (i.e. make sure that config update events are observed and the patch is re-applied as expected).
  • Add a test case to make sure that the port can be edited via the config.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions