refactor: update core/ scripts and add confdb support#25
Open
st3v3nmw wants to merge 2 commits into
Open
Conversation
st3v3nmw
changed the title
Member
Author
|
Hey @rajannpatel, @wck0, @Perfect5th, requesting a review for this. |
Collaborator
|
On the surface, this looks like a huge leap forward. @wck0 or @Perfect5th should weigh in |
|
This is really great and I hope I have time to test the scripts out soon, but I don't think we can merge until they are validated. I kind of wish this repository had some kind of automated testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
snap_httplibrary has gained first-class support for operations that previously required dropping down to raw snapd socket calls or calling internal methods likesnap_http.http.get()directly. Things like fetching logs and connecting interfaces now have proper high level APIs.The example scripts in
core/were written before many of these improvements landed, so this PR migrates them to use thesnap_httpAPI as it stands today. It also reorganizescore/into subdirectories that better reflect what each script does and updates the README to match.This PR also introduces a new
core/confdb/section covering the full confdb workflow: enabling experimental flags, acknowledging aconfdb-schemaassertion, getting and setting confdb view values, delegating & revoking operator access, and retrieving the resultingconfdb-controlassertion.