Skip to content

fix(forward-port): Use AWS env vars for IAM user (#306) #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NohaIhab merged 1 commit into from
Sep 10, 2026
Merged

fix(forward-port): Use AWS env vars for IAM user (#306) #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/pebble_component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ def get_layer(self) -> Layer:
"MINIO_PROMETHEUS_AUTH_TYPE": "public",
"MINIO_ROOT_USER": inputs.MINIO_ROOT_USER,
"MINIO_ROOT_PASSWORD": inputs.MINIO_ROOT_PASSWORD,
# Needed to ensure the Pod won't accidentally assume
# other IAM credentials (relevant for gateway mode on EKS only)
# https://github.com/canonical/kfp-operators/issues/785
"AWS_ACCESS_KEY_ID": inputs.MINIO_ROOT_USER,
"AWS_SECRET_ACCESS_KEY": inputs.MINIO_ROOT_PASSWORD,
},
}
},
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/test_charm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ def test_server_minio_args(harness, mock_kubernetes_service_patched):
assert environment["MINIO_ROOT_USER"] == "minio"
assert environment["MINIO_ROOT_PASSWORD"] == "test-key"
assert environment["MINIO_PROMETHEUS_AUTH_TYPE"] == "public"
assert environment["AWS_ACCESS_KEY_ID"] == "minio"
assert environment["AWS_SECRET_ACCESS_KEY"] == "test-key"

# Assert the command includes the console address with the specified port
expected_args = [
Expand Down
Loading