[DPE-9996] Make scale from zero check more robust - #295
Draft
astrojuanlu wants to merge 2 commits into
Draft
Conversation
astrojuanlu
force-pushed
the
juanlu/fix-scale-from-zero
branch
from
May 5, 2026 14:28
081845a to
cb97bb6
Compare
Contributor
Author
|
Contributor
Author
|
|
astrojuanlu
force-pushed
the
juanlu/fix-scale-from-zero
branch
from
June 10, 2026 07:05
fccf71b to
c11c689
Compare
Contributor
Author
|
This fix is too naïve: Despite this method being used in the machines charm since #288 (comment) Will need more thorough analysis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fix gh-293.
Solution
Checklist