[MISC] Refactor cluster-client methods - #78
Merged
Conversation
sinclert-canonical
added
the
not bug or enhancement
sinclert-canonical
marked this pull request as ready for review
September 3, 2026 09:34
sinclert-canonical
requested review from
Soundarya03,
astrojuanlu and
paulomach
September 3, 2026 09:34
astrojuanlu
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a refactor I wanted to done for a while.
It removes the
from,into,withinandbeforewords from the cluster-client method names. These words were meant to signal when a cluster-client method could be called without failure, but they can fail for any other reason (i.e. lack of cluster quorum), and it is quite uncommon for public API methods to include time prepositions in their names.This is a backwards incompatible change, we would need to bump the package version to
2.0.0when releasing.