Conversation
goss v0.4.10 removed the raw goss-linux-<arch> release assets and now ships per-arch tarballs (goss_<ver>_linux_<arch>.tar.gz). The pinned 'releases/latest/download/goss-linux-<arch>' URL therefore 404s, so curl saved GitHub's 'Not Found' page as the goss binary and kgoss failed in the test pod with 'goss: 1: Not: not found' (exit 127). Pin goss to v0.4.10, download the per-arch tarball and extract the goss binary, mapping dpkg arch (amd64->x86_64, arm64->arm64). Also pin the kgoss download to the same release.
Contributor
|
Sorry, didn't see this PR :) Already implemented for v1 at 30382d7 Closing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rock-pull-request.yamlinstalls goss via:goss
latestis now v0.4.10, which removed the rawgoss-linux-<arch>assets and now ships per-arch tarballs (e.g.goss_0.4.10_linux_x86_64.tar.gz). Soreleases/latest/download/goss-linux-amd64returns 404,curl -Lwrites GitHub's "Not Found" page into/usr/local/bin/goss, andkgossthen copies that text file into the test pod. Running it fails with:This breaks the
Testsjob for every rock repo consuming this reusable workflow at@v1.Fix
Pin goss to
v0.4.10, download the per-arch tarball, and extract thegossbinary, mappingdpkgarch to goss's naming (amd64→x86_64,arm64→arm64).kgossis still a standalone asset, so its download is pinned to the same release.Verified the pinned URLs return 200 for both
amd64(x86_64) andarm64, and that a full goss suite runs correctly with the extractedv0.4.10binary.Related