Conversation
smethnani
changed the title
izmalk
left a comment
izmalk
left a comment
There was a problem hiding this comment.
Looks good. I've made a few suggestions and a question about K8s Juju scaling.
| :sync: k8s | ||
|
|
||
| ```shell | ||
| juju add-unit opensearch-k8s |
There was a problem hiding this comment.
Question: Is it the same add-unit in K8s? I thought we have to use juju scale-application instead.
There was a problem hiding this comment.
It's what I've been using with k8s but I can see the juju docs do suggest scale-application. But they also say remove-unit <unit> works for k8s which doesn't (it needs to be just the application name with --num-units <n> or juju will complain) :/ I'll switch both to scale-application
| Charmed OpenSearch supports performance profiles with different RAM consumption: | ||
|
|
||
| * `production`: JVM heap set to 50% of the available RAM, capped at 31 GB | ||
| * `testing`: JVM heap fixed at ~1 GB of RAM |
There was a problem hiding this comment.
Suggestion: This part is exactly the same and has specific numbers. Let's move it outside of the tabs, so we won't need to duplicate it.
There was a problem hiding this comment.
Ah I was trying to avoid the revision part in k8s. I think it makes sense to move it to the next section's vm tab as I don't believe the k8s section needs this warning.
| :sync: k8s | ||
|
|
||
| ```shell | ||
| juju remove-unit opensearch-k8s --num-units 1 |
There was a problem hiding this comment.
Question: Same question about juju scale-application.
| [OpenSearch documentation about rolling upgrades](https://docs.opensearch.org/latest/migrate-or-upgrade/rolling-upgrade/#preparing-to-upgrade). | ||
|
|
||
| ### Check Juju status | ||
| **Check Juju status** |
There was a problem hiding this comment.
Suggestion: This is a big section below. And there is no alternative for K8s. I feel like we can drop the tabs here, for this section, and just add a warning at the start that K8s don't support this. That way we avoid sacrificing the convenience of proper headings and navigation for just having an almost empty K8s tab.
| [](https://charmhub.io/opensearch) | ||
| [](https://github.com/canonical/opensearch-operator/actions/workflows/release.yaml) | ||
| [](https://github.com/canonical/opensearch-operator/actions/workflows/ci.yaml) | ||
| [](https://github.com/canonical/opensearch-operator/actions/workflows/sync_docs.yaml) |
There was a problem hiding this comment.
praise: Thanks for fixing it.
2 participants
Adds upgrades on K8s docs
I moved the "recover from rollback" section to VM only as it hasn't been tested on K8s