Skip to content

fix(deps): hold typescript <7 for typescript-eslint 8.x - #1046

Open
f-atwi wants to merge 3 commits into
mainfrom
fix/pin-typescript-below-7
Open

fix(deps): hold typescript <7 for typescript-eslint 8.x#1046
f-atwi wants to merge 3 commits into
mainfrom
fix/pin-typescript-below-7

Conversation

@f-atwi

@f-atwi f-atwi commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Renovate #1042 bumped typescript to 7.0.0 but @typescript-eslint/eslint-plugin 8.x requires peer typescript >=4.8.4 <6.1.0, breaking npm ci (check/check-dist).

Pin typescript back to ~6.0.0, and add a Renovate rule capping typescript <7.0.0 until the lint stack supports it.

Applicable spec:

Overview

Rationale

Workflow Changes

Checklist

@f-atwi
fix(deps): hold typescript <7 for typescript-eslint 8.x and sync lock…
0828a69 
…file

Renovate #1042 bumped typescript to ^7.0.0 but @typescript-eslint/eslint-plugin
8.x requires peer typescript >=4.8.4 <6.1.0, breaking npm ci (check/check-dist).
Pin typescript back to ~6.0.0, regenerate the lockfile, and add a Renovate rule
capping typescript <7.0.0 until the lint stack supports it.
@f-atwi f-atwi self-assigned this Sep 3, 2026
@f-atwi f-atwi added the trivial label Sep 3, 2026
@f-atwi
f-atwi marked this pull request as ready for review September 3, 2026 09:05
@f-atwi
f-atwi requested a review from a team as a code owner September 3, 2026 09:05
@f-atwi
fix(deps): update TypeScript version constraint to <6.1.0 for compati…
12ce7a0 
…bility with @typescript-eslint
@f-atwi
chore: rebuild dist/ for updated dependency bundle
254d846 
Regenerating the lockfile pulled newer transitive deps (e.g. @actions/artifact)
into the rollup bundle; rebuild dist/ so check-dist matches. Built with the
pinned Node (.node-version 24.20.0).
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Test results for commit 254d846

Test coverage for 254d846

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-09-03 09:57:07.899349+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Test results for commit 254d846

Test coverage for 254d846

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-09-03 09:57:07.517206+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Test results for commit 254d846

Test coverage for 254d846

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-09-03 10:20:32.478650+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Test results for commit 254d846

Test coverage for 254d846

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-09-03 09:57:07.899349+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Test results for commit 254d846

Test coverage for 254d846

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-09-03 09:57:07.517206+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Test results for commit 254d846

Test coverage for 254d846

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-09-03 10:20:32.478650+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@f-atwi f-atwi

Labels

trivial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@f-atwi