Skip to content

feat: add support for arm64 - #37

Merged
michaeldmitry merged 11 commits into
mainfrom
TAP-727
Sep 18, 2025
Merged

michaeldmitry merged 11 commits into
mainfrom
TAP-727

Conversation

@michaeldmitry

@michaeldmitry michaeldmitry commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Fixes #27

Currently our CI doesn’t run itests using arm runners → fix
But, even when it does, it won’t work for our case. ATM, our self-hosted arm runners + gh arm runners don’t support nested virtualisation. Meaning that, juju won’t be able to deploy a machine of type virtual-machine, which is what we need for the profiler to work.

Sample error logs when trying to run the itests on arm runners

+ .machines['0'].machine_status.current = 'provisioning error'
+ .machines['0'].machine_status.message = 'Failed creating instance record: Instance type "virtual-machine" is not supported on this server: KVM support is missing (no /dev/kvm)'

UPDATE
Ran local tests locally on an arm machine and they all passed

Comment thread src/snap_management.py

@Gmerold Gmerold left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@michaeldmitry
michaeldmitry merged commit 255f768 into main Sep 18, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

release charm to arm64

3 participants