fix(backups): move pgBackRest log-level-stderr to its config file - #1898
Conversation
|
Thanks for the contribution, @xhon-pelushi! Could you address the following requirement?
|
|
Thanks @marceloneppel — understood on the signature requirement. The single commit on this branch ( While I was here: the one red check is stale rather than a real failure, and I think it just needs a re-run. but that job completed at |
@xhon-pelushi, you can force-push this PR. |
--log-level-stderr=warn was being passed as a CLI flag on almost every pgBackRest invocation individually (info, repo-ls, stanza-create, check, backup). Set it once in pgbackrest.conf.j2 instead, so it applies consistently to any command that loads this config without needing to be repeated at every call site. The server-ping health check in _is_primary_pgbackrest_service_running doesn't pass --config, so it doesn't read pgbackrest.conf - it keeps the explicit --log-level-stderr=warn flag to preserve its current logging behavior. Mirrors the equivalent change already applied on main/14-edge (canonical#1320, discussion_r2622432819) for the 16/edge branch, per canonical#1353. Fixes canonical#1767 Signed-off-by: xhon-pelushi <xhon@pelushi.com>
1cb4f40 to
3ec256d
Compare
|
Force-pushed as requested — the branch is now The tree is unchanged from Also still true from my last comment: the one red |
|
Heads-up on the red The force-push only attached a signature. Both commits point at the same tree, The suite looks broken repo-wide rather than branch-specific:
The failures are also upstream of anything this change touches — i.e. the install hook, before Happy to rebase onto a green |
|
@xhon-pelushi, I'll debug the failures and update here. |
3 participants
Fixes #1767
--log-level-stderr=warnwas passed as a CLI flag on almost everypgBackRest invocation individually. Set it once in
pgbackrest.conf.j2instead, so it applies consistently to any command that loads this
config, without repeating it at every call site.
_is_primary_pgbackrest_service_running'sserver-pinghealth checkdoesn't pass
--config, so it never readspgbackrest.conf— it keepsthe explicit
--log-level-stderr=warnflag so its logging behaviorisn't silently dropped.
Mirrors the equivalent change already open on
main/14-edge(#1750, for #1353, discussion_r2622432819) — this ports it to
16/edge,which hadn't picked it up yet.
Test plan
tox run -e unit— 222 passed, 0 failed (full suite, not just thetouched tests).
tox run -e lint(poetry check --lock,codespell,ruff check,ruff format --check) — clean on the changed files.poetry run ty check— all checks passed.