test(integration): cover IPv6 deployments; pin single-kernel lib to IPv6 fixes - #1937
Draft
marceloneppel wants to merge 6 commits into
Draft
test(integration): cover IPv6 deployments; pin single-kernel lib to IPv6 fixes#1937marceloneppel wants to merge 6 commits into
marceloneppel wants to merge 6 commits into
Conversation
Pin the single-kernel library to the 16/edge commit that brackets IPv6 literals in every URL it builds (Patroni REST API requests, patroni_url, primary health checks and client-facing endpoints). With a bare IPv6 literal, HTTP clients parse the address at the first colon and reject the URL (httpx.InvalidURL), which crashes every hook touching the cluster status on IPv6 clouds (#1928) because httpx.InvalidURL escapes the request helper's HTTPError/ValueError handling. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Add a jubilant integration test that deploys the charm with the peer relation binding forced to a Juju space holding only the IPv6 subnet, plus IPv4-only and dual-stack variants, and wire one spread task per scenario. On an IPv6 binding the charm's own cluster networking (Patroni REST API, cluster status queries) runs purely over IPv6, which is the condition that crashed every hook before the single-kernel library bracketed IPv6 literals in URL authorities (#1928). The get-primary action exercises the exact path that crashed: it queries the cluster status through the charm-built Patroni API URL. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
The scenario selector variables must be listed in the integration tox env's pass_env, otherwise tox strips them and the test silently runs as the dual-stack scenario instead of the requested address family. Parse the network-get binding output correctly: juju 3.6 returns addresses under bind-addresses[].addresses[].value. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Re-running the scenario against a model that already has the space must not fail: create the space only when absent, keeping the test idempotent like every other handler in the charm. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Bump the pin from 57606c1 to 76faaa9: on top of the URL-authority bracketing, the library now renders pg_hba rules matching IPv6 clients (::/0 twins for every IPv4 rule, ::1/128 loopback and /128 masks for IPv6 self addresses). Without them the bootstrap's own role-creation connection from the unit's IPv6 address is rejected with FATAL 28000 and Patroni cancels the bootstrap in a ~7s wipe-and-restart loop. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
github-actions
Bot
added
the
Libraries: Out of sync
The deterministic IPv6 prefix is configured on lxdbr0 after the controller bootstrapped, so Juju only learns the subnet through reload-spaces. Without it, add-space fails with 'subnet not found' on CI (where the prefix is set post-bootstrap), and the IPv6 scenario never reaches the deploy. The call was accidentally dropped when the space creation was made idempotent. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
On a Juju model whose peer relation binding resolves to an IPv6 address,
leader-electedfails withhttpx.InvalidURL: Invalid port: '...:8008'and the unit loops in hook-failed. Details and diagnosis: #1928 (internal DPE-11019). Two library-level causes: Patroni REST API URLs built from bare IPv6 literals (rejected by the HTTP clients — an IPv6 literal must be bracketed in a URL authority), and a renderedpg_hba.confwith only IPv4 CIDRs, which rejects Patroni's own bootstrap role-creation connection coming from the unit's IPv6 address (Patroni then cancels the initialization in a wipe-and-restart loop).Solution
The fixes live in the single-kernel library (
postgresql-single-kernel-libraryfix branch, commit 76faaa9168f7431b170e52865daab5631880d76f): IPv6 literals bracketed in every URL authority, and IPv6 twins for the rendered pg_hba rules (::/0per IPv4 rule,::1/128loopback, family-aware prefix lengths for self addresses). This PR pins the library to that commit, adds a jubilant integration test (tests/integration/test_ipv6_deployment.py) that deploys with the peer relation bound to an IPv6-only space plus IPv4-only and dual-stack variants, and wires the three spread tasks running it. Scenario selection is environment-driven (PG_IP_FAMILY,PG_IPV6_SUBNET) and passed through the integration tox env.Checklist