[DPE-7882] Reinstate logical replication on the single-kernel library - #1941
Draft
marceloneppel wants to merge 1 commit into
Draft
[DPE-7882] Reinstate logical replication on the single-kernel library#1941marceloneppel wants to merge 1 commit into
marceloneppel wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Libraries: Out of sync
Re-enables the logical replication feature the library now owns (canonical/postgresql-single-kernel-library#266..#270, pinned to 33c8fcb502677e8711c393528237e7522dc6440b until released): - config and metadata gain the subscription-request option and the two logical-replication relations back, - the charm constructs the library handler and re-wires apply_changed_config, retry_validations, the blocked-status reporting, and the update-status early-exit exemption, - the restore action rejects clusters with an active logical replication relation again, - adds tests/integration/ha_tests/test_logical_replication_circular.py verifying that cyclic setups block instead of looping inserts forever (#1085), adapted from the K8s charm's fix PR to the VM helpers. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
marceloneppel
force-pushed
the
dpe-7882-reinstate-logical-replication
branch
from
September 4, 2026 21:54
e7c9771 to
274b86e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Logical replication has been disabled in this charm since #1258 pending the module's migration onto the single-kernel library. Reinstating it also ships the fix for #1085 (cyclic logical replication setups loop inserts forever; they must be blocked instead).
Solution
postgresql-charms-single-kernelto the commit carrying the library's logical-replication migration PRs ([DPE-11044] feat(logical-replication): port the offer-side relation handler (1/5) postgresql-single-kernel-library#266..[DPE-2838] Secret labels #270, commit 33c8fcb502677e8711c393528237e7522dc6440b) until they are released as 16.3.11.logical-replication-subscription-requestoptions in config.yaml, the twological-replicationrelations in metadata.yaml, the handler construction and its hook wiring in charm.py, and the restore-action guard in backups.py.tests/integration/ha_tests/test_logical_replication_circular.py, adapted from the K8s charm's fix PR to the VM helpers, verifying that direct (A <-> B) and multi-hop (A -> B -> C -> A) circular setups end in a blocked status mentioning circular replication.Checklist