[DPE-11045] test(logical-replication): cover the ported module (5/5) - #270
Draft
marceloneppel wants to merge 2 commits into
Draft
[DPE-11045] test(logical-replication): cover the ported module (5/5)#270marceloneppel wants to merge 2 commits into
marceloneppel wants to merge 2 commits into
Conversation
Constructs the handler in the abstract charm (the composition root) and hands its replication_slots view to the config manager; the test charms gain the two logical-replication relations in their metadata. Ports the circular-replication coverage from the charms' fix PR onto the library test charms: chain building, subscriber and publisher circular checks, validation blocking, and stale-error handling on both substrates.
marceloneppel
force-pushed
the
lr-4-circular-validation
branch
from
September 4, 2026 21:51
6e55d8e to
9d7aaf0
Compare
marceloneppel
force-pushed
the
lr-5-tests
branch
from
September 4, 2026 21:51
33c8fcb to
f76c14a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Last PR of the logical replication migration series (after #269): unit coverage for the ported module, and the handler wiring into the library charms.
Solution
PostgreSQLLogicalReplicationinAbstractPostgreSQLCharm(the composition root) and hands itsreplication_slotsview to the config manager; the test charms gain the twological-replicationrelations in their metadata.Checklist