[DPE-11198] test(watcher): cover the watcher handler and bump to 16.3.14 (3/3) - #276
Draft
marceloneppel wants to merge 2 commits into
Draft
[DPE-11198] test(watcher): cover the watcher handler and bump to 16.3.14 (3/3)#276marceloneppel wants to merge 2 commits into
marceloneppel wants to merge 2 commits into
Conversation
marceloneppel
changed the base branch from
16/edge
to
watcher-2-wire-handler
September 4, 2026 21:54
….14 (3/3) Ports the VM charm's watcher relation unit tests over the substrate parameterised harness: the Raft address composition (including the invalid-port guard), the raft-status active gate, the joined/changed/broken event flows, the leader-only relation-data handout, the per-unit address and availability-zone publishing, the secret update on credential rotation, and the secret get-or-create paths. Every test skips on the k8s substrate: the watcher relation exists only in the VM charm's metadata. Bumps the library version to 16.3.14.
…ow-up) Strengthens the ported tests per the faithfulness review: - The joined-leader flow now asserts the full cluster-information share: the secret grant to the watcher relation and the relation-data update (the source test's grant/_update_relation_data assertions). - Adds the missing joined no-secret test: a failed secret creation defers the event. - The leader handout test now also asserts raft-secret-id, raft-partner-addrs (fresh units_ips) and standby-clusters, which the port had dropped.
marceloneppel
force-pushed
the
watcher-2-wire-handler
branch
from
September 4, 2026 22:00
1451fb6 to
916bc8c
Compare
marceloneppel
force-pushed
the
watcher-3-tests-version
branch
from
September 4, 2026 22:00
191b8e7 to
3d94784
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Stacks on #274 and #275.
Solution
test_watcher_relation.py) over the substrate-parameterised harness: the Raft address composition (including the invalid-port guard), theraft-statusactive gate, the joined/changed/broken event flows, the leader-only relation-data handout (cluster-name, raft-secret-id, raft-partner-addrs, raft-port, patroni-cas, standby-clusters, tls-enabled), the per-unit address and availability-zone publishing, the secret update on credential rotation, and the secret get-or-create paths. The joined-leader flow asserts the full cluster-information share (secret grant to the watcher relation + relation-data update), and the no-secret path defers, matching the charm's tests plus the gaps they left.