test(async-replication): cover the events handler (7/8) - #283
Draft
marceloneppel wants to merge 1 commit into
Draft
test(async-replication): cover the events handler (7/8)#283marceloneppel wants to merge 1 commit into
marceloneppel wants to merge 1 commit into
Conversation
marceloneppel
force-pushed
the
async-replication-6-manager-tests
branch
from
September 4, 2026 23:07
ed5e75b to
0ae0f70
Compare
marceloneppel
force-pushed
the
async-replication-7-events-tests
branch
from
September 4, 2026 23:08
932ebc5 to
d2402a6
Compare
marceloneppel
force-pushed
the
async-replication-6-manager-tests
branch
from
September 4, 2026 23:23
0ae0f70 to
87ab9ba
Compare
marceloneppel
force-pushed
the
async-replication-7-events-tests
branch
from
September 4, 2026 23:23
d2402a6 to
d68d8f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Covers the events handler ported in 3/8 and 4/8, driving real framework events so the guards, defers and substrate branches stay in the path.
Solution
name+ status), stale-counter clearing before the guard (DPE-10203), mirrored-counter kept, consumer-side rejection;set_app_statusmessages,handle_read_only_mode, and the_same_secret_idhelper.Known coverage gaps against the charm originals (flagged by the pre-merge faithfulness review, follow-up candidates): the K8s
standby-pgdata-clearedonce-only gating, the force-promotion reachability failure path, the non-leader_wait_for_standby_leaderpaths (isolated restart / defer),_configure_primary_cluster's primary-side branches, and the offer-sidesecret_changedbranch — the latter three are additionally exercised by the adoption PRs' adapted charm tests.