feat: source cosTool from cosl - #846
Merged
Merged
Conversation
sinapah
commented
Jul 10, 2026
sinapah
marked this pull request as ready for review
July 10, 2026 19:24
MichaelThamm
approved these changes
Jul 10, 2026
MichaelThamm
approved these changes
Jul 13, 2026
sinapah
added a commit
that referenced
this pull request
Jul 13, 2026
* fix: Integration test_logging (#840) * feat(tf): base input variable (#842) * feat: source `cosTool` from cosl (#846) * feat: source from cosl * fix: remove casts for OfficialRuleFileFormat * fix: remove pr wf change * chore(track/3.11): fetch-lib --------- Co-authored-by: Michael Thamm <mike.thamm@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Similar to canonical/loki-k8s-operator#607.
Before canonical/cos-lib#202 goes in, we should source CosTool in these two libs from
coslto pull all the performance efficiency changes easily.Solution
Replaces the local CosTool clone so it can be sourced from
cosl.Context
Testing Instructions
Once merged, if we decide we want the perf improvements of canonical/cos-lib#202 in tracks 2 and 3, then we should backport the changes of this PR using
charmcraft fetch-libin those two tracks.Upgrade Notes